Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #184

Merged
merged 173 commits into from
Sep 3, 2024
Merged
Changes from 3 commits
Commits
Show all changes
173 commits
Select commit Hold shift + click to select a range
3bf5902
Merge pull request #69 from madhansansel/main
rukapse Jul 23, 2024
4735942
Merge pull request #71 from madhansansel/main
rukapse Jul 24, 2024
af886fd
Merge pull request #3 from ajithandrewj/user_and_role_workflow_feature
ajithandrewj Jul 31, 2024
56d11a2
Adding files
ajithandrewj Jul 31, 2024
82ed910
accesspoint_update_feature adding integration test code for accesspoi…
sonalideepthi777 Aug 1, 2024
4b52cab
accesspoint_update_feature modified integration test code for accessp…
sonalideepthi777 Aug 1, 2024
969cfc3
accesspoint_update_feature new modified integration test code for acc…
sonalideepthi777 Aug 1, 2024
e73cc12
Merge pull request #326 from cisco-en-programmability/main
madhansansel Aug 2, 2024
d9722ad
Add default code review template
madhansansel Aug 2, 2024
ec88567
Merge pull request #3 from sonalideepthi777/accesspoint_update_featur…
md-rafeek Aug 2, 2024
2ee9d3e
Update ansible.cfg
md-rafeek Aug 2, 2024
6722456
have add the code for version routing in the dnac.py
syed-khadeerahmed Aug 5, 2024
95638f3
Fix for unreacable revices, ap devices and unmanaged devices backup
abimishr Aug 5, 2024
6e00a11
Code Review template
madhansansel Aug 6, 2024
97d9c01
Fix for unreachable devices, ap devices and unmanaged devices backup
abimishr Aug 6, 2024
755930c
Merge pull request #329 from abimishr/PNP_Code_Abinash
madhansansel Aug 6, 2024
7c0ebc4
sanity error solved
syed-khadeerahmed Aug 6, 2024
104717e
Merge pull request #328 from syed-khadeerahmed/dnac_update_feature
madhansansel Aug 6, 2024
a7ce294
File Fetch
ajithandrewj Aug 6, 2024
2db5aff
Merge remote-tracking branch 'madhansansel/main' into user_and_role_w…
ajithandrewj Aug 6, 2024
e92fb7a
Adding fix for the issues related to typographical error, unused vari…
abimishr Aug 6, 2024
2cff61b
Delete playbooks/ansible.cfg
md-rafeek Aug 6, 2024
66f5d8d
Merge pull request #327 from md-rafeek/accesspoint_update_feature_all…
madhansansel Aug 6, 2024
294bcb7
Merge pull request #330 from abimishr/PNP_Code_Abinash
madhansansel Aug 6, 2024
50a2949
Adding log message
madhansansel Aug 7, 2024
4d9e6fa
merging madhan main
ajithandrewj Aug 7, 2024
76e0868
minor bugs and enhancement fixed
ajithandrewj Aug 7, 2024
eb8d811
Bugs Fixed
ajithandrewj Aug 7, 2024
6243972
swim UT test cases and fixtures started
syed-khadeerahmed Aug 7, 2024
4801989
demo test commit
rukapse Aug 7, 2024
781baed
demo test commit
rukapse Aug 7, 2024
634822a
Merge pull request #333 from rukapse/dev
madhansansel Aug 7, 2024
96f39f1
Write the code for the creation/updation/deletion of fabric sites and…
Abhishek-121 Aug 7, 2024
558a714
Added the limitation of the module in the notes section of documentation
Abhishek-121 Aug 7, 2024
56aa266
added sda_extranet_policies_workflow_manager
rukapse Aug 8, 2024
f2227c4
Added sample playbook for sda_extranet_policies_workflow_manager
rukapse Aug 8, 2024
77f2eb4
sanity bug fixes'
rukapse Aug 8, 2024
c2718c2
sanity bug fixes
rukapse Aug 8, 2024
cc902ff
sanity bug fixes
rukapse Aug 8, 2024
ee9b538
sanity bug fixes
rukapse Aug 8, 2024
e1feffa
UT code for site workflow manager
Kandarimegha Aug 8, 2024
56f175f
Updated user and role workflow feature
ajithandrewj Aug 8, 2024
ac7e327
2 test cases added
syed-khadeerahmed Aug 8, 2024
e2c9907
Updated user and role workflow feature
ajithandrewj Aug 8, 2024
5c69034
Updated user and role workflow feature
ajithandrewj Aug 8, 2024
12c562e
Merge pull request #332 from ajithandrewj/user_and_role_workflow_feature
madhansansel Aug 8, 2024
e9b8509
Updated user and role workflow feature
ajithandrewj Aug 8, 2024
ff307b5
untag test case compleated
syed-khadeerahmed Aug 8, 2024
048a4bf
Adding site as a paramter for device configs backup
abimishr Aug 9, 2024
c71972c
Optimized the code for the reserving the subpool
Aug 9, 2024
1afea70
Adding site as a paramter for device configs backup
abimishr Aug 9, 2024
5cc4a6a
Merge pull request #337 from abimishr/PNP_Code_Abinash
madhansansel Aug 9, 2024
9f46b75
demo commit
rukapse Aug 9, 2024
12a14e3
demo commit
rukapse Aug 9, 2024
c0fab0a
demo commit
rukapse Aug 9, 2024
c32c2e6
Merge pull request #335 from rukapse/dev
madhansansel Aug 9, 2024
244e5ec
test commit
rukapse Aug 9, 2024
c0ceb5a
Merge pull request #341 from rukapse/dev
madhansansel Aug 9, 2024
0d6eace
Merge pull request #342 from cisco-en-programmability/main
madhansansel Aug 10, 2024
b99bfe8
Merge branch 'madhansansel:main' into main
Abhishek-121 Aug 12, 2024
356ce12
Fix the issue of resyncing more than 400 devices in inventory.
Abhishek-121 Aug 13, 2024
e73618b
Merge branch 'madhansansel:main' into main
MUTHU-RAKESH-27 Aug 13, 2024
9fd78e6
Fix the issue of swim tagging/untagging for Global site
Abhishek-121 Aug 13, 2024
7566e52
swim UT 70% compleated
syed-khadeerahmed Aug 13, 2024
8aca2f6
Delete plugins/modules/fabric_sites_zones_workflow_manager.py
Abhishek-121 Aug 13, 2024
1f4ed6c
Delete playbooks/fabric_sites_zones_workflow_manager.yml
Abhishek-121 Aug 13, 2024
5355a69
Addressed the review comments
Aug 13, 2024
6bbc0c4
SWIM UT compleated
syed-khadeerahmed Aug 13, 2024
6ca439e
Merge pull request #338 from MUTHU-RAKESH-27/main
madhansansel Aug 13, 2024
2d7f3fd
SWIM UT compleated
syed-khadeerahmed Aug 13, 2024
7f6ebf4
SWIM playbook
syed-khadeerahmed Aug 13, 2024
3d3c239
SWIM playbook
syed-khadeerahmed Aug 13, 2024
3597092
changes after sanity check
Kandarimegha Aug 13, 2024
613e964
sanity done for JSON
syed-khadeerahmed Aug 14, 2024
9e0aef3
changes done
Kandarimegha Aug 14, 2024
5030b0a
updated the code with version based routing and bug fixed
ajithandrewj Aug 14, 2024
4d07377
user_role_workflow_manager bugs fixed
ajithandrewj Aug 14, 2024
8e1d800
updated user_role_workflow_feature
ajithandrewj Aug 14, 2024
f9e0486
updated user_role_workflow_feature
ajithandrewj Aug 14, 2024
cf0b2ec
Merge pull request #339 from ajithandrewj/user_and_role_workflow_feature
madhansansel Aug 14, 2024
9cdea29
RMA bug fixed
ajithandrewj Aug 14, 2024
db0fbe0
RMA bug fixed
ajithandrewj Aug 14, 2024
eca1cb8
CI after approve
sledzikowy Aug 14, 2024
2ecb6fb
fixes
sledzikowy Aug 14, 2024
2dfb813
add codeowners
sledzikowy Aug 14, 2024
46bb6af
Merge pull request #347 from madhansansel/sledzikowy/ci_on_approve
madhansansel Aug 14, 2024
a8dcb36
Updated rma_workflow_manager.py file
ajithandrewj Aug 15, 2024
1e345a6
Merge pull request #346 from ajithandrewj/rma_workflow_feature
madhansansel Aug 15, 2024
82f7790
user role workflow feature bugs fixed
ajithandrewj Aug 15, 2024
27bf429
bug fixed
ajithandrewj Aug 15, 2024
3b3aab5
Merge pull request #344 from syed-khadeerahmed/swim_workflow_feature
madhansansel Aug 16, 2024
3dbf3a2
Merge pull request #336 from Kandarimegha/Site_workflow_UT
madhansansel Aug 16, 2024
db5caa2
updated user_role_workflow_manager.py file
ajithandrewj Aug 16, 2024
4342e4d
updated user_role_workflow_manager.py file
ajithandrewj Aug 16, 2024
951b0e9
Merge pull request #348 from ajithandrewj/user_and_role_workflow_feature
madhansansel Aug 16, 2024
612744a
CSCwm06839
ajithandrewj Aug 19, 2024
1fe1f9e
CSCwm06839 - RMA bug fixed
ajithandrewj Aug 19, 2024
08cbbf6
Merge pull request #349 from ajithandrewj/rma_workflow_feature
madhansansel Aug 19, 2024
ab5eb9c
user_role_workflow_feature enhancement done and bugs fixed
ajithandrewj Aug 19, 2024
1969e0e
updated user_role_workflow_feature code
ajithandrewj Aug 20, 2024
59ecd92
Merge pull request #350 from ajithandrewj/user_and_role_workflow_feature
madhansansel Aug 20, 2024
e056051
CSCwm07436, CSCwm07948, CSCwm26614 - user_role_workflow_manager bugs …
ajithandrewj Aug 20, 2024
32e768e
user_role_workflow_manager bugs fixed - CSCwm07436, CSCwm07948, CSCwm…
ajithandrewj Aug 20, 2024
def95d9
rma_workflow_manager bug fixed - CSCwm26351
ajithandrewj Aug 20, 2024
1c14690
rma_workflow_manager bug fixed - CSCwm26351
ajithandrewj Aug 20, 2024
60aaff7
user_role_workflow_manager bug fixed
ajithandrewj Aug 21, 2024
8b56d0e
Merge branch 'main' into user_and_role_workflow_feature
ajithandrewj Aug 21, 2024
4d360ef
Merge pull request #353 from ajithandrewj/rma_workflow_feature
madhansansel Aug 21, 2024
6f7f0c6
Merge branch 'madhansansel/main' into user_and_role_workflow_feature
ajithandrewj Aug 21, 2024
86389fa
Bug raised for the 9 issue was fixed.
md-rafeek Aug 21, 2024
59d79b5
Bug raised for the 9 issue was fixed.
md-rafeek Aug 21, 2024
3ac49b8
user_role_workflow_manager bug fixed
ajithandrewj Aug 22, 2024
1845d56
user_role_workflow_manager bug fixed
ajithandrewj Aug 22, 2024
6118282
Fixed code review comments
md-rafeek Aug 22, 2024
a007093
Sanity issue on the lenth of line
md-rafeek Aug 22, 2024
15820c4
Merge pull request #356 from md-rafeek/accesspoint_update_feature_all…
madhansansel Aug 22, 2024
9e7c6db
AP update V1 to V2 to support clean air
md-rafeek Aug 23, 2024
b3817bd
Merge branch 'main' into accesspoint_update_feature_all_fields
madhansansel Aug 23, 2024
285c190
Merge pull request #357 from md-rafeek/accesspoint_update_feature_all…
madhansansel Aug 23, 2024
b8134f8
user_role_workflow_manager comments fixed
ajithandrewj Aug 23, 2024
c034b70
Merge branch 'main' into user_and_role_workflow_feature
ajithandrewj Aug 23, 2024
9b6a5e9
user_role_workflow_manager comments fixed
ajithandrewj Aug 23, 2024
6f19354
user_role_workflow_manager comments fixed
ajithandrewj Aug 23, 2024
ee5a8aa
Merge pull request #352 from ajithandrewj/user_and_role_workflow_feature
madhansansel Aug 23, 2024
85fd5ee
check vars
sledzikowy Aug 20, 2024
5f8a45a
store ansible logs on internal vm
sledzikowy Aug 20, 2024
0d6f231
add no_proxy
sledzikowy Aug 20, 2024
6c99cd1
disable StrictHostKeyCheck
sledzikowy Aug 20, 2024
03e98a4
fix permissions
sledzikowy Aug 20, 2024
0b0fa9f
fix
sledzikowy Aug 20, 2024
39cc30c
init rc file
sledzikowy Aug 20, 2024
2c42981
don't use context var for ip
sledzikowy Aug 20, 2024
d6b5ed1
Don't run everytime
sledzikowy Aug 20, 2024
e57c55d
Fix shellcheck
sledzikowy Aug 21, 2024
07daabc
remove trailing spae
sledzikowy Aug 23, 2024
1f10720
Pass sanity tests when there's nothing to execute
sledzikowy Aug 23, 2024
2f09ccd
Disable dry-run
sledzikowy Aug 23, 2024
e1cfa9e
Merge branch 'main' into abmahesh_resync_device
Abhishek-121 Aug 27, 2024
bb39b32
RMA bugs fixed
ajithandrewj Aug 27, 2024
94daddc
RMA bugs fixed
ajithandrewj Aug 28, 2024
6bbd835
RMA bugs fixed
ajithandrewj Aug 28, 2024
c229152
Merge branch 'main' into rma_workflow_feature
ajithandrewj Aug 28, 2024
568b0db
user_role_workflow_manager bug fixed
ajithandrewj Aug 28, 2024
458121c
Merge branch 'main' into user_and_role_workflow_feature
ajithandrewj Aug 28, 2024
e043263
RMA bugs fixed
ajithandrewj Aug 29, 2024
54d132c
RMA bugs fixed
ajithandrewj Aug 29, 2024
dad5ea4
Merge pull request #343 from Abhishek-121/abmahesh_resync_device
madhansansel Aug 29, 2024
7043391
Address the review comments of previous PR for the new module fabric_…
Abhishek-121 Aug 29, 2024
0fe7ffb
RMA bugs fixed
ajithandrewj Aug 29, 2024
ec02baf
Merge branch 'main' into rma_workflow_feature
ajithandrewj Aug 29, 2024
5909e6b
RMA bugs fixed
ajithandrewj Aug 29, 2024
90c983e
Merge branch 'main' into user_and_role_workflow_feature
ajithandrewj Aug 29, 2024
72b199d
user and roles comments fixed
ajithandrewj Aug 29, 2024
ba82df8
Merge branch 'main' of https://github.com/Abhishek-121/dnacenter-ansible
Abhishek-121 Aug 29, 2024
db188e1
fabric sites zones review comments addressed
Abhishek-121 Aug 29, 2024
4be909a
Address the review comment of previous PR for the bug fix of resync d…
Abhishek-121 Aug 29, 2024
db55584
RMA comments fixed
ajithandrewj Aug 30, 2024
bc6ff03
User and Roles comments fixed
ajithandrewj Aug 30, 2024
3c19104
RMA comments fixed
ajithandrewj Aug 30, 2024
2922299
add permissions
sledzikowy Aug 30, 2024
a1607f0
Move automerge to seperate workflow
sledzikowy Aug 30, 2024
feb1357
Merge pull request #361 from sledzikowy/fix_automerge
madhansansel Aug 30, 2024
2f79cab
RMA comments fixed
ajithandrewj Aug 30, 2024
ce23223
User and Roles comments fixed
ajithandrewj Aug 30, 2024
a37a5da
Merge branch 'main' into user_and_role_workflow_feature
ajithandrewj Aug 30, 2024
a5e79c1
RMA comments fixed
ajithandrewj Aug 30, 2024
40f62f0
Merge branch 'main' into rma_workflow_feature
ajithandrewj Aug 30, 2024
d920e4e
Merge pull request #359 from ajithandrewj/user_and_role_workflow_feature
madhansansel Aug 30, 2024
775b266
Merge pull request #360 from Abhishek-121/main
madhansansel Aug 30, 2024
90c5ee9
Merge pull request #358 from ajithandrewj/rma_workflow_feature
madhansansel Aug 30, 2024
525f85b
changes in workflow manager module
madhansansel Aug 30, 2024
5968937
Merge pull request #183 from madhansansel/main
bvargasre Sep 3, 2024
d99c193
updated compatibility matrix
bvargasre Sep 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 35 additions & 7 deletions plugins/modules/device_configs_backup_workflow_manager.py
Original file line number Diff line number Diff line change
@@ -279,7 +279,7 @@ def get_device_ids_list(self):
Args:
self: The instance of the class containing the 'config' attribute to be validated.
Returns:
dev_id_list: The list of device ids based on the parameters passed by the user
device_ids: The list of device ids based on the parameters passed by the user
Example:
Stored paramters like management ip address/ family can be used to fetch the device ids
list
@@ -300,16 +300,44 @@ def get_device_ids_list(self):
)
self.log("Response collected from the API 'get_device_list' is {0}".format(str(response)), "DEBUG")
device_list = response.get("response")

self.log("Length of the device list fetched from the API 'get_device_list' is {0}".format(str(device_list)), "INFO")
if len(device_list) == 0:
msg = "Couldn't find any devices in the inventory that match the given parameters."
original_valid_device_count = len(device_list)
if original_valid_device_count == 0:
msg = "No devices found in the inventory matching the given parameters."
self.log(msg, "CRITICAL")
self.module.fail_json(msg=msg)

valid_devices = []
for dev_info in device_list:
ip_address = dev_info.get("managementIpAddress")
if dev_info.get("collectionStatus") != "Managed":
msg = "Device backup of device with IP address {0} \
is not possible due to collection status not being in Managed state".format(ip_address)
self.log(msg, "WARNING")

elif dev_info.get("family") != "Unified AP":
msg = "Device backup of device with IP address {0} \
is not possible due to device being an Unified AP".format(ip_address)
self.log(msg, "WARNING")

elif dev_info.get("reachabilityStatus") != "Reachable":
msg = "Device backup of device with IP address {0} \
is not possible due to device being not reachable".format(ip_address)
self.log(msg, "WARNING")
else:
valid_devices.append(dev_info)

if len(valid_devices) == 0:
msg = "No device IDs were collected because the devices are either Unified APs \
not in the Managed state, or not reachable."
self.log(msg, "CRITICAL")
self.module.fail_json(msg=msg)

dev_id_list = [id.get("id") for id in device_list]
self.log("Device Ids list collected is {0}".format(dev_id_list), "INFO")
return dev_id_list
device_ids = [id.get("id") for id in valid_devices]
valid_device_count = len(device_ids)
self.log("Collected device IDs: {0}".format(device_ids), "INFO")
self.log("Backup of {0} devices out of {1} devices is possible".format(valid_device_count, original_valid_device_count), "INFO")
return device_ids

def password_generator(self):
"""