Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop v6.13.1 #159

Merged
merged 44 commits into from
Mar 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
01e1eff
Write the API for the creation/updation of tag for devices/interfaces…
Abhishek-121 Mar 5, 2024
540d82f
add space after comma in playbook
Abhishek-121 Mar 5, 2024
cac8268
Merge branch 'madhansansel:main' into main
Abhishek-121 Mar 12, 2024
8c98401
Adding fix for nonetype error in global credentials
abimishr Mar 12, 2024
d3f357c
Merge branch 'main' into PNP_Code_Abinash
abimishr Mar 12, 2024
89a5c29
Adding fix for nonetype error in global credentials
abimishr Mar 12, 2024
a2f87b5
Merge branch 'PNP_Code_Abinash' of https://github.com/abimishr/dnacen…
abimishr Mar 12, 2024
6999107
Adding fix for nonetype error in global credentials
abimishr Mar 12, 2024
fba3a3a
Revert "add space after comma in playbook"
Abhishek-121 Mar 12, 2024
f97653a
Revert "Write the API for the creation/updation of tag for devices/in…
Abhishek-121 Mar 12, 2024
fc6e818
Merge pull request #190 from abimishr/PNP_Code_Abinash
madhansansel Mar 12, 2024
dfc0b29
Fix the issue while creating building site without optional parameter…
Abhishek-121 Mar 13, 2024
77e1472
swim distribution/activation flag added in begining
Abhishek-121 Mar 13, 2024
e586b72
change code to support python older versions
Abhishek-121 Mar 13, 2024
e97c240
fix the issue of updating management ip for device with snmp_version v2
Abhishek-121 Mar 13, 2024
6268644
Merge pull request #192 from cisco-en-programmability/main
madhansansel Mar 13, 2024
a47a0a2
Fix the issue of Un-tagging image if it's inherited from parent site …
Abhishek-121 Mar 13, 2024
95bd7ba
Add whitspaces after the while loop
Abhishek-121 Mar 13, 2024
8c88ac2
Merge pull request #191 from Abhishek-121/main
madhansansel Mar 13, 2024
726648e
Adding documentation for the EWLC template issue in CCC 235x
abimishr Mar 15, 2024
cab86c5
Adding documentation for the EWLC template issue in CCC 235x
abimishr Mar 15, 2024
7f6a01a
Fix the issue of log message while editing the management IP of devic…
Abhishek-121 Mar 15, 2024
ea93310
Add max timeout while checking the distribution/activation stautus of…
Abhishek-121 Mar 15, 2024
198819d
Adding documentation for the EWLC template issue in CCC 235x
abimishr Mar 15, 2024
aac0d33
Merge pull request #193 from abimishr/PNP_Code_Abinash
madhansansel Mar 15, 2024
cf8ffdb
Changes in discovery, site, swim and inventory workflow manager modules
madhansansel Mar 15, 2024
e3eb4d2
Made the import project and export template/project work for the SDK
Mar 17, 2024
93387d6
Made the import project and export template/project work for the SDK
Mar 17, 2024
f50af17
Addressed the review comments
Mar 17, 2024
e859f9d
Merge pull request #196 from MUTHU-RAKESH-27/main
madhansansel Mar 17, 2024
5ee425f
Introduce max_timeout, interval_seconds options to be given by user a…
Abhishek-121 Mar 18, 2024
0862db8
Add danc_api_task_timeout, dnac_task_poll_interval options into workf…
Abhishek-121 Mar 18, 2024
a9ce141
add danc_api_task_timeout, dnac_task_poll_interval parameter in the a…
Abhishek-121 Mar 18, 2024
b39d9c3
Added attributes in inventory manager module
madhansansel Mar 18, 2024
dcc8e66
Merge pull request #194 from Abhishek-121/main
madhansansel Mar 18, 2024
76f3486
Changes in workflow manager modules
madhansansel Mar 18, 2024
923a13c
Changing danc into dnac
madhansansel Mar 19, 2024
b3adc2d
Remove dnac_api_task_timeout, dnac_task_poll_interval options from th…
Abhishek-121 Mar 20, 2024
1739623
remove extra line
Abhishek-121 Mar 20, 2024
820e2da
Update log messages for update operation if device not found
Abhishek-121 Mar 21, 2024
717fd9b
Merge pull request #197 from Abhishek-121/main
madhansansel Mar 21, 2024
1b90b81
Adding fix for intermittent failure of Discovery
abimishr Mar 21, 2024
7a40e3f
Merge pull request #198 from abimishr/PNP_Code_Abinash
madhansansel Mar 21, 2024
8d256a7
Merge pull request #158 from madhansansel/main
fmunozmiranda Mar 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion changelogs/changelog.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -834,4 +834,18 @@ releases:
changes:
release_summary: Changes the minimum supported version of Ansible to v2.14.0
minor_changes:
- Changes the minimum supported version from Ansible v2.9.10 to v2.14.0
- Changes the minimum supported version from Ansible v2.9.10 to v2.14.0
6.13.1:
release_date: "2024-03-15"
changes:
release_summary: Enhancements in discovery, site, swim and inventory workflow manager modules.
minor_changes:
- Introduced sample playbooks for the discovery module.
- Resolved a 'NoneType' error in discovery module credentials.
- Corrected site creation issues in the site module when optional parameters are missing.
- Fixed management IP updates for devices on SNMP version v2.
- Addressed image un-tagging issues in inherited site settings.
- Provided documentation for EWLC templates in Cisco Catalyst Center version 2.3.7.x.
- Added attributes 'dnac_api_task_timeout' and 'dnac_task_poll_interval' in intent and workflow_manager modules.
- inventory_workflow_manager - Added attributes 'add_user_defined_field', 'update_interface_details', 'export_device_list' and 'admin_status'
- inventory_workflow_manager - Removed attributes 'provision_wireless_device', 'reprovision_wired_device'
2 changes: 1 addition & 1 deletion galaxy.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
namespace: cisco
name: dnac
version: 6.13.0
version: 6.13.1
readme: README.md
authors:
- Rafael Campos <[email protected]>
Expand Down
8 changes: 3 additions & 5 deletions playbooks/discovery_intent.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@
auth_password: Lablab#1234
privacy_type: AES256
privacy_password: Lablab#1234
global_cli_len: 3
protocol_order: ssh

- name: Execute discovery of single device using various discovery specific credentials only
Expand All @@ -99,6 +98,7 @@
discovery_type: "SINGLE"
ip_address_list:
- 204.1.2.5
use_global_credentials: False
discovery_specific_credentials:
cli_credentials_list:
- username: cisco
Expand All @@ -122,11 +122,9 @@
auth_password: Lablab#1234
privacy_type: AES256
privacy_password: Lablab#1234
global_cli_len: 3
use_global_cred: False
protocol_order: ssh

- name: Execute discovery devices using MULTI RANGE with various discovery specific credentials
- name: Execute discovery devices using MULTI RANGE with various discovery specific credentials and all global credentials (max 5 allowed)
cisco.dnac.discovery_intent:
<<: *dnac_login
state: merged
Expand Down Expand Up @@ -164,7 +162,7 @@
records_to_return: 1000
snmp_version: v2

- name: Execute discovery devices using CDP/LLDP/CIDR
- name: Execute discovery devices using CDP/LLDP/CIDR leveraging discovery specific credentials and all the global credentials
cisco.dnac.discovery_intent:
<<: *dnac_login
state: merged
Expand Down
8 changes: 3 additions & 5 deletions playbooks/discovery_workflow_manager.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@
auth_password: Lablab#1234
privacy_type: AES256
privacy_password: Lablab#1234
global_cli_len: 3
protocol_order: ssh

- name: Execute discovery of single device using various discovery specific credentials only
Expand All @@ -99,6 +98,7 @@
discovery_type: "SINGLE"
ip_address_list:
- 204.1.2.5
use_global_credentials: False
discovery_specific_credentials:
cli_credentials_list:
- username: cisco
Expand All @@ -122,11 +122,9 @@
auth_password: Lablab#1234
privacy_type: AES256
privacy_password: Lablab#1234
global_cli_len: 3
use_global_cred: False
protocol_order: ssh

- name: Execute discovery devices using MULTI RANGE with various discovery specific credentials
- name: Execute discovery devices using MULTI RANGE with various discovery specific credentials and all global credentials (max 5 allowed)
cisco.dnac.discovery_workflow_manager:
<<: *dnac_login
state: merged
Expand Down Expand Up @@ -164,7 +162,7 @@
records_to_return: 1000
snmp_version: v2

- name: Execute discovery devices using CDP/LLDP/CIDR
- name: Execute discovery devices using CDP/LLDP/CIDR leveraging discovery specific credentials and all the global credentials
cisco.dnac.discovery_workflow_manager:
<<: *dnac_login
state: merged
Expand Down
34 changes: 1 addition & 33 deletions playbooks/inventory_workflow_manager.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,12 @@
snmp_ro_community: "{{item.snmp_ro_community}}"
snmp_rw_community: "{{item.snmp_rw_community}}"
snmp_username: "{{item.snmp_username}}"
device_updated: "{{item.device_updated}}"
credential_update: "{{item.credential_update}}"
clean_config: "{{item.clean_config}}"
type: "{{item.type}}"
device_resync: "{{item.device_resync}}"
reboot_device: "{{item.reboot_device}}"
update_device_role:
role: "{{item.role}}"
role: "{{item.role}}"
add_user_defined_field:
- name: Test123
description: "Added first udf for testing"
Expand All @@ -58,36 +56,6 @@
site_name: "Global/USA/San Francisco/BGL_18/floor_test"
resync_retry_count: 200
resync_retry_interval: 2
provision_wireless_device:
- device_ip: "1.1.1.1"
site_name: "Global/USA/BGL_18/floor_pnp"
managed_ap_locations: ["Global/USA/BGL_18/floor_pnp", "Global/USA/BGL_18/floor_test"]
dynamic_interfaces:
- interface_ip_address: 23.23.21.12
interface_netmask_in_cidr: 24
interface_gateway: "gateway"
lag_or_port_number: 12
vlan_id: 99
interface_name: "etherenet0/0"
resync_retry_count: 200
resync_retry_interval: 2
- device_ip: "2.2.2.2"
site_name: "Global/USA/BGL_18/floor_test"
managed_ap_locations: ["Global/USA/BGL_19/floor_pnp", "Global/USA/BGL_19/floor_test"]
dynamic_interfaces:
- interface_ip_address: 32.31.12.23
interface_netmask_in_cidr: 26
interface_gateway: "gateway_test"
lag_or_port_number: 33
vlan_id: 78
interface_name: "etherenet1/1"
resync_retry_count: 200
resync_retry_interval: 2
reprovision_wired_device:
- device_ip: "1.1.1.1"
site_name: "Global/USA/San Francisco/BGL_18/floor_pnp"
- device_ip: "2.2.2.2"
site_name: "Global/USA/San Francisco/BGL_18/floor_test"
update_interface_details:
description: "{{item.update_interface_details.description}}"
interface_name: "{{item.interface_name}}"
Expand Down
28 changes: 15 additions & 13 deletions playbooks/swim_workflow_manager.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,27 +19,29 @@
dnac_log: True
dnac_log_level: DEBUG
config_verify: True
dnac_api_task_timeout: 1000
dnac_task_poll_interval: 1
config:
- import_image_details:
type: "{{ item.type }}"
url_details:
payload:
- source_url: http://10.197.156.28/stda/abimishr/cat9k_iosxe.17.12.01.SPA.bin
- source_url: http://172.21.236.183/swim/V1712_2_CCO/cat9k_iosxe.17.12.02.SPA.bin
third_party: False
tagging_details:
image_name: "{{item.image_name}}"
image_name: cat9k_iosxe.17.12.02.SPA.bin
device_role: ALL
device_image_family_name: Cisco Catalyst 9300 Switch
site_name: "{{item.site_name}}"
device_role: "{{ item.device_role }}"
device_image_family_name: "{{ item.device_image_family_name }}"
tagging: False
image_distribution_details:
image_name: "{{item.image_name}}"
site_name: "{{item.site_name}}"
device_role: "{{ item.device_role }}"
device_family_name: "{{ item.device_family_name }}"
device_series_name: "Catalyst 9300 Series"
tagging: True
# image_distribution_details:
# image_name: cat9k_iosxe.17.12.02.SPA.bin
# site_name: "{{item.site_name}}"
# device_role: "{{ item.device_role }}"
# device_family_name: "{{ item.device_family_name }}"
# device_series_name: "Catalyst 9300 Series"
image_activation_details:
image_name: "{{item.image_name}}"
image_name: cat9k_iosxe.17.12.02.SPA.bin
site_name: "{{item.site_name}}"
device_role: "{{ item.device_role }}"
device_family_name: "{{ item.device_family_name }}"
Expand All @@ -49,4 +51,4 @@

with_items: "{{ image_details }}"
tags:
- swim
- swim
9 changes: 9 additions & 0 deletions plugins/doc_fragments/intent_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,15 @@ class ModuleDocFragment(object):
description: Determines the mode of the file. Set to True for 'append' mode. Set to False for 'write' mode.
type: bool
default: True
dnac_api_task_timeout:
description: Defines the timeout in seconds for API calls to retrieve task details. If the task details
are not received within this period, the process will end, and a timeout notification will be logged.
type: int
default: 1200
dnac_task_poll_interval:
description: Specifies the interval in seconds between successive calls to the API to retrieve task details.
type: int
default: 2
validate_response_schema:
description:
- Flag for Cisco DNA Center SDK to enable the validation of request bodies against a JSON schema.
Expand Down
9 changes: 9 additions & 0 deletions plugins/doc_fragments/workflow_manager_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,15 @@ class ModuleDocFragment(object):
- Flag for Cisco Catalyst Center SDK to enable the validation of request bodies against a JSON schema.
type: bool
default: true
dnac_api_task_timeout:
description: Defines the timeout in seconds for API calls to retrieve task details. If the task details
are not received within this period, the process will end, and a timeout notification will be logged.
type: int
default: 1200
dnac_task_poll_interval:
description: Specifies the interval in seconds between successive calls to the API to retrieve task details.
type: int
default: 2
notes:
- "Does not support C(check_mode)"
- "The plugin runs on the control node and does not use any ansible connection plugins instead embedded connection manager from Cisco Catalyst Center SDK"
Expand Down
2 changes: 2 additions & 0 deletions plugins/modules/device_credential_intent.py
Original file line number Diff line number Diff line change
Expand Up @@ -2583,6 +2583,8 @@ def main():
"dnac_log_file_path": {"type": 'str', "default": 'dnac.log'},
"dnac_log_append": {"type": 'bool', "default": True},
"config_verify": {"type": 'bool', "default": False},
'dnac_api_task_timeout': {'type': 'int', "default": 1200},
'dnac_task_poll_interval': {'type': 'int', "default": 2},
"config": {"type": 'list', "required": True, "elements": 'dict'},
"state": {"default": 'merged', "choices": ['merged', 'deleted']},
"validate_response_schema": {"type": 'bool', "default": True},
Expand Down
2 changes: 2 additions & 0 deletions plugins/modules/device_credential_workflow_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -2582,6 +2582,8 @@ def main():
"dnac_log_file_path": {"type": 'str', "default": 'dnac.log'},
"dnac_log_append": {"type": 'bool', "default": True},
"config_verify": {"type": 'bool', "default": False},
'dnac_api_task_timeout': {'type': 'int', "default": 1200},
'dnac_task_poll_interval': {'type': 'int', "default": 2},
"config": {"type": 'list', "required": True, "elements": 'dict'},
"state": {"default": 'merged', "choices": ['merged', 'deleted']},
"validate_response_schema": {"type": 'bool', "default": True},
Expand Down
Loading
Loading