Stackswith getting changed to normal switch #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the device's info
…ing the device's info
Adding fix for Stackswitch getting changed to normal switch post editing the device's info
|
@wastorga Can you please check and approve? |
|
Hi @madhansansel. Could you add it to the changelog please? @bvargasre and @fmunozmiranda have not yet published the last PR (have not release version 6.12.0). Tell us if you want to publish these changes with version 6.12.0 or as a new version. Finally, (@bvargasre and @fmunozmiranda) please verify that the release date matches. |
|
HI @wastorga! |
Updated the changelog.yaml about the stack switch getting converted to normal switch.
|
Hi @wastorga , updated the change log file . Thank you for your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description:
Whenever the user tries to claim a Stack Switch using the playbook and tries to edit the device info like hostname/serial_number/pid, then it automatically gets converted to a normal switch.
Root Cause:
This conversion happens due to a bug in the update_device API under PnP, which automatically makes stack as False if not passed in the payload.
Code Changes: Have added a check for the stack. If the device is a stack, it automatically takes stack as True for passing the payload to the API, bypassing the bug.