Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection not compatible with ansible.utils 5.x.y #192

Closed
Tracked by #223
felixfontein opened this issue Oct 15, 2024 · 4 comments
Closed
Tracked by #223

Collection not compatible with ansible.utils 5.x.y #192

felixfontein opened this issue Oct 15, 2024 · 4 comments

Comments

@felixfontein
Copy link

This collection is currently not compatible with ansible.utils 5.x.y per its galaxy.yml dependencies entry. ansible.utils 5.0.0 has been released ~four months ago.

According to the Ansible inclusion requirements (https://docs.ansible.com/ansible/devel/community/collection_contributors/collection_requirements.html#collection-dependencies), if you depend on any other collection, you have to make sure to be compatible to ansible.util's latest version in a timely manner.

The requirements state:

In case a collection depends on releases of a new major version outside of this version range that will be included in the next major Ansible release, the dependent collection will be removed from the next major Ansible release. The cut-off date for this is feature freeze.

The Ansible 11 feature freeze is on November 5th, which is in three weeks. Please make sure to:

  1. Update galaxy.yml's dependencies entry and make sure your collection is compatible to ansible.utils 5.x.y;
  2. Release a new version with that change (note that dependency range updates should only be done in minor or major releases).

Thanks!

@fmunozmiranda
Copy link
Collaborator

Updated, If there is nothing else I can help you with, please close the issue.

@mariolenz
Copy link

@fmunozmiranda Just change it in the source code isn't enough. You should release a new version supporting ansible.utils 5.x. But it looks like you did...

@felixfontein Are we happy with this? At first glance, I think it's OK.

@felixfontein
Copy link
Author

Thanks, bumping the requirements and doing the release fixed this. (Verified in ansible-community/ansible-build-data#482.)

Something unrelated: I looked into changelogs/changelog.yaml and noticed that some entries are not strings, but one-element dictionaries; for example: https://github.com/cisco-en-programmability/dnacenter-ansible/blob/main/changelogs/changelog.yaml#L1015-L1017 You can see this from the syntax highlighting. These entries will be ignored by the Ansible changelog, as they are invalid.

(You might want to use antsibull-changelog lint-changelog-yaml /path/to/changelog.yaml to lint the changelogs/changelog.yaml file: https://ansible.readthedocs.io/projects/antsibull-changelog/changelog.yaml-format/)

@mariolenz
Copy link

Thanks @fmunozmiranda!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants