Skip to content

Commit

Permalink
Merge pull request #29 from cisco-en-programmability/develop_dnac_2_2…
Browse files Browse the repository at this point in the history
…_3_3

Add qos_device_interface and fixes tag_member
  • Loading branch information
wastorga authored Dec 14, 2021
2 parents 4e60a59 + e31987f commit dbb3d1d
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 11 deletions.
9 changes: 6 additions & 3 deletions changelogs/changelog.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -300,9 +300,12 @@ releases:
- sda_virtual_network_ip_pool - remove `payload` and `ipPoolName` parameter.
- sda_virtual_network_ip_pool - add `siteNameHierarchy`, `ipPoolName`, `trafficType`, `authenticationPolicyName`, `scalableGroupName`, `isL2FloodingEnabled`, `isThisCriticalPool`, `poolType`, `vlanName`, `isWirelessPool` parameters.
4.1.0:
release_date: '2021-12-07'
release_date: '2021-12-14'
changes:
release_summary: Add qos_device_interface
release_summary: Add qos_device_interface and fixes tag_member
minor_changes:
- qos_device_interface - new module.
- qos_device_interface_info - new module.
- qos_device_interface_info - new module.
bugfixes:
- tag_member - change object param to use payload.
- tag_member - update module documentation.
7 changes: 3 additions & 4 deletions plugins/action/tag_member.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
# Add arguments specific for this module
argument_spec.update(dict(
state=dict(type="str", default="present", choices=["present", "absent"]),
object=dict(type="str"),
payload=dict(type="dict"),
id=dict(type="str"),
memberId=dict(type="str"),
))
Expand All @@ -49,14 +49,14 @@ class TagMember(object):
def __init__(self, params, dnac):
self.dnac = dnac
self.new_object = dict(
object=params.get("object"),
payload=params.get("payload"),
id=params.get("id"),
member_id=params.get("memberId"),
)

def create_params(self):
new_object_params = {}
new_object_params['object'] = self.new_object.get('object')
new_object_params['payload'] = self.new_object.get('payload')
new_object_params['id'] = self.new_object.get('id')
return new_object_params

Expand Down Expand Up @@ -117,7 +117,6 @@ def requires_update(self, current_obj):
requested_obj = self.new_object

obj_params = [
("object", "object"),
("id", "id"),
("memberId", "member_id"),
]
Expand Down
9 changes: 5 additions & 4 deletions plugins/modules/tag_member.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
memberId:
description: MemberId path parameter. TagMember id to be removed from tag.
type: str
object:
description: Object.
type: str
payload:
description: Map of member type and member ids.
type: dict
requirements:
- dnacentersdk >= 2.4.0
- python >= 3.5
Expand All @@ -46,7 +46,8 @@
dnac_debug: "{{dnac_debug}}"
state: present
id: string
object: string
payload:
networkinterface: ["string"]
- name: Delete by id
cisco.dnac.tag_member:
Expand Down

0 comments on commit dbb3d1d

Please sign in to comment.