Devel error in modules and actions

cisco-en-programmability · Nov 19, 2024 · 7180c57 · 7180c57
1 parent ab44850
commit 7180c57
Show file tree

Hide file tree

Showing 47 changed files with 12 additions and 837 deletions.
diff --git a/plugins/action/accesspoint_configuration_details_by_task_id_info.py b/plugins/action/accesspoint_configuration_details_by_task_id_info.py
@@ -15,4 +15,4 @@ def __init__(self, *args, **kwargs):
     def run(self, tmp=None, task_vars=None):
         module = ActionModule(self._task.args, self._play_context, self._task)
         return module.run(tmp, task_vars)
-
+
diff --git a/plugins/action/application_policy_application_set_v2.py b/plugins/action/application_policy_application_set_v2.py
@@ -3,7 +3,6 @@
 
 # Copyright (c) 2021, Cisco Systems
 # GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
-
 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 from ansible.plugins.action import ActionBase

diff --git a/plugins/action/business_sda_hostonboarding_ssid_ippool_v1.py b/plugins/action/business_sda_hostonboarding_ssid_ippool_v1.py
@@ -22,9 +22,6 @@
     dnac_compare_equality,
     get_dict_result,
 )
-from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
-)
 
 # Get common arguments specification
 argument_spec = dnac_argument_spec()

diff --git a/plugins/action/compliance_device.py b/plugins/action/compliance_device.py
diff --git a/plugins/action/compliance_device_v1.py b/plugins/action/compliance_device_v1.py
diff --git a/plugins/action/event_snmp_config_v1.py b/plugins/action/event_snmp_config_v1.py
@@ -20,7 +20,6 @@
     DNACSDK,
     dnac_argument_spec,
     dnac_compare_equality,
-    get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
     InconsistentParameters,

diff --git a/plugins/action/images_site_wise_product_names_v1.py b/plugins/action/images_site_wise_product_names_v1.py
@@ -143,7 +143,6 @@ def exists(self):
             _name = prev_obj.get("name")
             _name = _name or prev_obj.get("productNameOrdinal")
             if _name:
-                        _payload_first.update(dict(productNameOrdinal=_name))
                 self.new_object.update(dict(product_name_ordinal=_name))
         if name_exists:
             _id = prev_obj.get("id")

diff --git a/plugins/action/network_devices_network_profiles_for_sites_v1.py b/plugins/action/network_devices_network_profiles_for_sites_v1.py
@@ -194,6 +194,17 @@ def run(self, tmp=None, task_vars=None):
 
         response = None
         if state == "present":
+            (obj_exists, prev_obj) = obj.exists()
+            if obj_exists:
+                if obj.requires_update(prev_obj):
+                    response = prev_obj
+                    dnac.object_present_and_different()
+                else:
+                    response = prev_obj
+                    dnac.object_already_present()
+            else:
+                dnac.fail_json(
+                    "Object does not exists")
         elif state == "absent":
             (obj_exists, prev_obj) = obj.exists()
             if obj_exists:

diff --git a/plugins/action/sda_anycast_gateways_v1.py b/plugins/action/sda_anycast_gateways_v1.py
@@ -23,7 +23,6 @@
     get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
     AnsibleSDAException,
 )
 

diff --git a/plugins/action/sda_authentication_profiles_v1.py b/plugins/action/sda_authentication_profiles_v1.py
@@ -23,7 +23,6 @@
     get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
     AnsibleSDAException,
 )
 

diff --git a/plugins/action/sda_extranet_policies_v1.py b/plugins/action/sda_extranet_policies_v1.py
@@ -23,7 +23,6 @@
     get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
     AnsibleSDAException,
 )
 

diff --git a/plugins/action/sda_fabric_authentication_profile_v1.py b/plugins/action/sda_fabric_authentication_profile_v1.py
@@ -23,7 +23,6 @@
     get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
     AnsibleSDAException,
 )
 

diff --git a/plugins/action/sda_fabric_border_device_v1.py b/plugins/action/sda_fabric_border_device_v1.py
@@ -23,7 +23,6 @@
     get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
     AnsibleSDAException,
 )
 

diff --git a/plugins/action/sda_fabric_control_plane_device_v1.py b/plugins/action/sda_fabric_control_plane_device_v1.py
@@ -23,7 +23,6 @@
     get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
     AnsibleSDAException,
 )
 

diff --git a/plugins/action/sda_fabric_devices_layer2_handoffs_ip_transits_v1.py b/plugins/action/sda_fabric_devices_layer2_handoffs_ip_transits_v1.py
@@ -23,7 +23,6 @@
     get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
     AnsibleSDAException,
 )
 

diff --git a/plugins/action/sda_fabric_devices_layer2_handoffs_sda_transits_v1.py b/plugins/action/sda_fabric_devices_layer2_handoffs_sda_transits_v1.py
@@ -23,7 +23,6 @@
     get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
     AnsibleSDAException,
 )
 

diff --git a/plugins/action/sda_fabric_devices_layer2_handoffs_v1.py b/plugins/action/sda_fabric_devices_layer2_handoffs_v1.py
@@ -23,7 +23,6 @@
     get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
     AnsibleSDAException,
 )
 

diff --git a/plugins/action/sda_fabric_devices_v1.py b/plugins/action/sda_fabric_devices_v1.py
@@ -23,7 +23,6 @@
     get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
     AnsibleSDAException,
 )
 

diff --git a/plugins/action/sda_fabric_edge_device_v1.py b/plugins/action/sda_fabric_edge_device_v1.py
@@ -23,7 +23,6 @@
     get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
     AnsibleSDAException,
 )
 

diff --git a/plugins/action/sda_fabric_site_v1.py b/plugins/action/sda_fabric_site_v1.py
@@ -23,7 +23,6 @@
     get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
     AnsibleSDAException,
 )
 

diff --git a/plugins/action/sda_fabric_sites_v1.py b/plugins/action/sda_fabric_sites_v1.py
@@ -23,7 +23,6 @@
     get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
     AnsibleSDAException,
 )
 

diff --git a/plugins/action/sda_fabric_zones_v1.py b/plugins/action/sda_fabric_zones_v1.py
@@ -23,7 +23,6 @@
     get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
     AnsibleSDAException,
 )
 

diff --git a/plugins/action/sda_fabrics_vlan_to_ssids_fabric_id_v1.py b/plugins/action/sda_fabrics_vlan_to_ssids_fabric_id_v1.py
@@ -23,7 +23,6 @@
     get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
     AnsibleSDAException,
 )
 

diff --git a/plugins/action/sda_layer2_virtual_networks_v1.py b/plugins/action/sda_layer2_virtual_networks_v1.py
@@ -23,7 +23,6 @@
     get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
     AnsibleSDAException,
 )
 

diff --git a/plugins/action/sda_layer3_virtual_networks_v1.py b/plugins/action/sda_layer3_virtual_networks_v1.py
@@ -23,7 +23,6 @@
     get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
     AnsibleSDAException,
 )
 

diff --git a/plugins/action/sda_multicast_v1.py b/plugins/action/sda_multicast_v1.py
@@ -23,7 +23,6 @@
     get_dict_result,
 )
 from ansible_collections.cisco.dnac.plugins.plugin_utils.exceptions import (
-    InconsistentParameters,
     AnsibleSDAException,
 )
Original file line number	Diff line number	Diff line change
Expand Up		@@ -15,4 +15,4 @@ def __init__(self, args, *kwargs):
		def run(self, tmp=None, task_vars=None):
		module = ActionModule(self._task.args, self._play_context, self._task)
		return module.run(tmp, task_vars)