Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of LaTeX warning #116

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Get rid of LaTeX warning #116

merged 4 commits into from
Nov 28, 2023

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Nov 27, 2023 •
edited
Loading

🗣 Description

This pull request makes some changes to the LaTeX template to get rid of a LaTeX warning.

💭 Motivation and context

Resolves #114.

🧪 Testing

All automated tests pass. I also built a Docker image with these changes and verified that it functions as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.
  • Build and test a new Docker image containing these changes.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number labels Nov 27, 2023
@jsf9k jsf9k self-assigned this Nov 27, 2023
@jsf9k
Call \phantomsection and create a hypertarget for a \subsection*
74d29ba 
Resolves #114.

This change makes this \subsection* identical to others in this same
document.
@jsf9k jsf9k force-pushed the improvement/get-rid-of-latex-warnings branch from da88433 to 74d29ba Compare November 27, 2023 18:38
@jsf9k jsf9k changed the title Get rid of LaTeX warnings Get rid of LaTeX warning Nov 27, 2023
@jsf9k jsf9k marked this pull request as ready for review November 27, 2023 19:00
@jsf9k jsf9k requested review from felddy and a team November 27, 2023 19:01
dav3r
dav3r approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@jsf9k jsf9k enabled auto-merge November 28, 2023 18:37
@jsf9k jsf9k merged commit 051b5b7 into develop Nov 28, 2023
14 checks passed
@jsf9k jsf9k deleted the improvement/get-rid-of-latex-warnings branch November 28, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@dav3r dav3r dav3r approved these changes

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

@felddy felddy Awaiting requested review from felddy

Assignees

@jsf9k jsf9k

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number
Projects
BOD 18-01
Status: Done
CyHy System
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of hyperref anchor warning
3 participants
@jsf9k @dav3r @dv4harr10