Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move sys.exit() calls to main() #47

Open
2 tasks
jsf9k opened this issue Jun 30, 2021 · 0 comments
Open
2 tasks

Move sys.exit() calls to main() #47

jsf9k opened this issue Jun 30, 2021 · 0 comments
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@jsf9k
Copy link
Member

jsf9k commented Jun 30, 2021

💡 Summary

Move all sys.exit() type calls to main().

Motivation and context

Decisions to exit early should take place at the highest possible level. See also this discussion in #44.

Acceptance criteria

  • All sys.exit() type calls are moved to main().
  • The Docker image continues to function as expected.
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jun 30, 2021
@jsf9k jsf9k mentioned this issue Jun 30, 2021
Merged
9 tasks
jsf9k pushed a commit that referenced this issue Jul 17, 2021
@mcdonnnj
Merge pull request #47 from cisagov/improvement/autoupdate_pre-commit
3634093 
Autoupdates to pre-commit Hooks for 2020-07
jsf9k pushed a commit that referenced this issue Jul 17, 2021
@mcdonnnj
Merge pull request #47 from cisagov/improvement/fix_agency_name
6012923 
Correct the Agency Name for Docker Images
@mcdonnnj mcdonnnj moved this to To do in BOD 18-01 Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
BOD 18-01
Status: To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsf9k