Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make container tests functional #43

Open
1 task
jsf9k opened this issue Jun 29, 2021 · 0 comments
Open
1 task

Make container tests functional #43

jsf9k opened this issue Jun 29, 2021 · 0 comments
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@jsf9k
Copy link
Member

jsf9k commented Jun 29, 2021 •
edited by dav3r
Loading

💡 Summary

In #44 I commented out most of the tests because the container as it stands does not support them. The container should be altered to support these tests, at which point they should be uncommented again.

Motivation and context

Containers should undergo some testing as a part of the CI process.

Acceptance criteria

  • All possible tests are supported by the container, and passing in GitHub Actions.
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jun 29, 2021
jsf9k added a commit that referenced this issue Jun 29, 2021
@jsf9k
Comment out failing tests
637437f 
I created #43 to circle back and correctly implement these tests.
jsf9k added a commit that referenced this issue Jun 29, 2021
@jsf9k
Comment out failing tests
e81a35d 
I created #43 to circle back and correctly implement these tests.
jsf9k pushed a commit that referenced this issue Jul 17, 2021
@mcdonnnj
Merge pull request #43 from cisagov/lineage/skeleton
f3f257e 
⚠️ CONFLICT! Lineage pull request for: skeleton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsf9k