Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the latest version of Python #66

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Use the latest version of Python #66

merged 2 commits into from
Dec 19, 2022

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Dec 19, 2022 •
edited
Loading

🗣 Description

This pull request modifies Dockerfile to use a base Docker image based on the latest version of Python.

💭 Motivation and context

The latest version of Python is generally more performant than previous versions; plus, it's always good to stay current.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Dec 19, 2022
@jsf9k jsf9k self-assigned this Dec 19, 2022
dav3r
dav3r approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsf9k jsf9k marked this pull request as ready for review December 19, 2022 16:26
@jsf9k jsf9k requested a review from mcdonnnj as a code owner December 19, 2022 16:26
mcdonnnj
mcdonnnj approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jsf9k jsf9k merged commit 2aacaa1 into develop Dec 19, 2022
@jsf9k jsf9k deleted the improvement/use-latest-python branch December 19, 2022 16:49
jsf9k added a commit to cisagov/orchestrator that referenced this pull request Dec 19, 2022
@jsf9k
Use the latest Docker images
cea2d9a 
These updated Docker images use the latest possible version of Python.

See these PRs for more details:
* cisagov/gatherer#95
* cisagov/pshtt_reporter#78
* cisagov/saver#66
* cisagov/scanner#71
* cisagov/trustymail_reporter#102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@mcdonnnj mcdonnnj mcdonnnj approved these changes

Assignees

@jsf9k jsf9k

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
BOD 18-01
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @mcdonnnj