Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for sslyze 3 (superset of PR #214) #248

Merged
merged 15 commits into from
Oct 16, 2023
Merged

Add support for sslyze 3 (superset of PR #214) #248

merged 15 commits into from
Oct 16, 2023

Conversation

felddy
Copy link
Member

@felddy felddy commented Oct 16, 2023 •
edited
Loading

🗣 Description

This PR contains a superset of the commits of PR:

💭 Motivation and context

🧪 Testing

Testing is incomplete at this time.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@felddy felddy self-assigned this Oct 16, 2023
@felddy felddy added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use upstream update This issue or pull request pulls in upstream updates hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation labels Oct 16, 2023
SaptakS and others added 11 commits October 16, 2023 14:17
@SaptakS @felddy
Adds support for sslyze>=3.0.0
b494399 
- fixes import errors for the current required modules
- uses the new format for certificate analyzer
- updates dependency of sslyze to >=3.0.0
@SaptakS @felddy
Adds extra certificate informations for user trusted CA
f4512a6
@SaptakS @felddy
Fixes typo in comment
81882c4
@SaptakS @mcdonnnj @felddy
Add fixes and suggestions from code review
bd6957c 
- fix comments
- use == instead of is

Co-authored-by: Nick M. <[email protected]>
@SaptakS @felddy
Consider all certificate deployments instead of first one
4a3207f 
- consider all deployments and if all validations succeed, then
consider it trusted
- use path_validation_results instead of received_certificate_chain
to consider if STORE is included in trust_store
- check self signed validation in cert_chain till the second last
cert since the last cert is root cert and hence is self signed anyways
- put all logic inside one loop over path_validation_results
@SaptakS @felddy
Consider all certificate deployments for verified certificate chain
35047c8
@SaptakS @felddy
Updates sslyze version to <5.0.0, upgrade required python to >=3.7
f11b04c
@SaptakS @felddy
Lints the python code
822a381
@SaptakS @felddy
Updates python versions in github workflow build
67cfaf9
@SaptakS @felddy
Updates python version in build.yml
aae0882
@SaptakS @felddy
Removes Python 3.6 from build
2e4fb16
@felddy felddy marked this pull request as ready for review October 16, 2023 18:46
@felddy
Remove Python requirements from README
3005fc5 
This is documented in setup.py.
No one will be amazed that it doesn't support Python 2.
jsf9k
jsf9k approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval intensifies!!!

dav3r
dav3r approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@felddy felddy changed the title Add support for sslyze 3 (mirror of PR #214) Add support for sslyze 3 (superset of PR #214) Oct 16, 2023
@felddy felddy merged commit 4f9b94f into develop Oct 16, 2023
35 of 38 checks passed
@felddy felddy deleted the improvement/sslyze3 branch October 16, 2023 19:58
@felddy felddy mentioned this pull request Oct 16, 2023
Closed
6 tasks
@jsf9k jsf9k mentioned this pull request Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@felddy felddy

Labels
hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use upstream update This issue or pull request pulls in upstream updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felddy @jsf9k @dav3r @SaptakS