-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the latest cisagov/domain scan code #108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is being done to test the changes in cisagov/domain-scan#6. This change can be reverted once cisagov/domain-scan#6 is approved and merged.
jsf9k
added
upstream update
This issue or pull request pulls in upstream updates
version bump
This issue or pull request increments the version number
docker
Pull requests that update Docker code
labels
Nov 26, 2023
5 tasks
Hi Team, In the Description the first link appears to be broken, returns error 'can't reach this page." |
dv4harr10
approved these changes
Nov 27, 2023
Thanks @dv4harr10. It's now fixed. |
dav3r
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This reverts commit e663917. We can do this now that cisagov/domain-scan#6 has been merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docker
Pull requests that update Docker code
upstream update
This issue or pull request pulls in upstream updates
version bump
This issue or pull request increments the version number
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request modifies this Docker container to use the latest code from cisagov/domain-scan, specifically the changes from cisagov/domain-scan#6.
💭 Motivation and context
This enables us to test cisagov/domain-scan#6 and hence resolve cisagov/domain-scan#7.
🧪 Testing
All automated tests pass. I also built a new Docker image containing these changes and verified that it functioned as expected.
✅ Pre-approval checklist
✅ Pre-merge checklist
strip_wildcard
regex domain-scan#6 has been approved and merged.✅ Post-merge checklist