-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document ability to add organizational metadata and complying with SCuBA policy checks via configuration file #1443
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a number of suggestions for tweaks to the documentation and/or configuration. See below.
Co-authored-by: Addam Schroll <[email protected]>
Co-authored-by: Addam Schroll <[email protected]>
Co-authored-by: Addam Schroll <[email protected]>
Co-authored-by: Addam Schroll <[email protected]>
Is there a schema for these config files? What stops organizations from populating them with whatever fields they want? Or to ask this question a different way, why do we need to create a sample that specifically uses OrgName and OrgUnitName? Or to ask yet another way, what would happen if they used OrganizationName and OrganizationUnit (or whatever fields they made up) instead of these? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things to adjust or at least to have a conversation about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks ready. TY for responding to all my requests for info.
🗣 Description
💭 Motivation and context
Closes #1425
🧪 Testing
Invoke-SCuBA -ConfigFilePath scuba_compliance.yaml
to see if current config file is valid.✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
Demonstrate changes to the team for questions and comments.
(Note: Only required for issues of size
Medium
or larger)✅ Post-merge checklist