Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SCB acronym to read as "Secure Configuration Baseline" throughout repo #1440

Merged
merged 15 commits into from
Dec 12, 2024
Merged

Update SCB acronym to read as "Secure Configuration Baseline" throughout repo #1440

merged 15 commits into from
Dec 12, 2024

Conversation

ahuynhMITRE
Copy link
Collaborator

@ahuynhMITRE ahuynhMITRE commented Nov 22, 2024 •
edited by nanda-katikaneni
Loading

🗣 Description

We have been referencing SCB as both "Security Configuration Baseline" and "Secure Configuration Baseline". This PR and accompanying issue addresses the inconsistency and updates all references to "Secure Configuration Baseline" to match BOD language.

💭 Motivation and context

Change is required to have the acronym of SCB to be consistently referred as "Secure Configuration Baseline" matching the BOD language. Using a the replace functionality this has been done throughout the repo.

Closes #1432

🧪 Testing

Check throughout the repo that "Security Configuration Baseline" instances have been replaced with "Secure Configuration Baseline".

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@ahuynhMITRE ahuynhMITRE added documentation This issue or pull request improves or adds to documentation baseline-document Issues relating to the text in the baseline documents themselves labels Nov 22, 2024
@ahuynhMITRE ahuynhMITRE added this to the Kraken milestone Nov 22, 2024
@ahuynhMITRE ahuynhMITRE self-assigned this Nov 22, 2024
@ahuynhMITRE ahuynhMITRE linked an issue Nov 22, 2024 that may be closed by this pull request
Update SCB acronym to be synonymous with "Secure Configuration Baseline" for consistency #1432
Closed
1 task
@ahuynhMITRE ahuynhMITRE requested a review from gdasher December 2, 2024 15:23
@schrolla schrolla force-pushed the 1432-update-scb-acronym-to-be-synonymous-with-secure-configuration-baseline-for-consistency branch from c73502b to 6c628a7 Compare December 9, 2024 15:23
mitchelbaker-cisa
mitchelbaker-cisa previously approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@mitchelbaker-cisa mitchelbaker-cisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, doubled checked files throughout Sample-Reports and /docs directory.

@mitchelbaker-cisa mitchelbaker-cisa force-pushed the 1432-update-scb-acronym-to-be-synonymous-with-secure-configuration-baseline-for-consistency branch from 6c628a7 to ff14dd6 Compare December 9, 2024 21:01
@mitchelbaker-cisa mitchelbaker-cisa dismissed their stale review December 9, 2024 23:27

Reviewing again to check sample-reports output

mitchelbaker-cisa
mitchelbaker-cisa requested changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@mitchelbaker-cisa mitchelbaker-cisa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one remaining location to update in the README.md.

Screenshot (352)

Occurrences in /Sample-Reports are related to Defender 5.1 which is updated in this PR. All sample report files will be updated by #1466.

Screenshot (354)

gdasher
gdasher approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@gdasher gdasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahuynhMITRE
Copy link
Collaborator Author

@nanda-katikaneni good to merge

@nanda-katikaneni nanda-katikaneni merged commit 4fa115e into main Dec 12, 2024
22 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 1432-update-scb-acronym-to-be-synonymous-with-secure-configuration-baseline-for-consistency branch December 12, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdasher gdasher gdasher approved these changes

@mitchelbaker-cisa mitchelbaker-cisa mitchelbaker-cisa approved these changes

Assignees

@ahuynhMITRE ahuynhMITRE

Labels
baseline-document Issues relating to the text in the baseline documents themselves documentation This issue or pull request improves or adds to documentation
Projects
None yet
Milestone
Kraken
Development

Successfully merging this pull request may close these issues.

Update SCB acronym to be synonymous with "Secure Configuration Baseline" for consistency
4 participants
@ahuynhMITRE @gdasher @mitchelbaker-cisa @nanda-katikaneni