Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct bug with Connect-IPPSSession error handling #1199

Merged

Conversation

adhilto
Copy link
Collaborator

@adhilto adhilto commented Jul 4, 2024

🗣 Description

Ensure the DLPLicense variable gets defined even if Connect-IPPSSession throws an exception.

💭 Motivation and context

Closes #1191.

🧪 Testing

  • Tested on a tenant with an expired license - results in invalid json on main
  • Tested on a tenant with an expired license - exception properly handled on this branch, no malformed json produced
  • Tested on a tenant that does not result in an exception - executed like normal as expected

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@adhilto adhilto added the bug This issue or pull request addresses broken functionality label Jul 4, 2024
@adhilto adhilto added this to the Iceberg milestone Jul 4, 2024
@adhilto adhilto self-assigned this Jul 4, 2024
@adhilto adhilto linked an issue Jul 4, 2024 that may be closed by this pull request
Copy link
Collaborator

@dagarwal-mitre dagarwal-mitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@james-garriss james-garriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@adhilto
Copy link
Collaborator Author

adhilto commented Jul 9, 2024

@nanda-katikaneni this one's ready to merge

@nanda-katikaneni nanda-katikaneni merged commit 34d4e60 into main Jul 9, 2024
19 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 1191-improper-handling-of-connect-ippssession-errors branch July 9, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper Handling of Connect-IPPSSession Errors
4 participants