-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional shields.io badges to README #1167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Love it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thing we only switched to mainly PSGallery once we hit 10K downloads for the package :)
Added a post-merge check to see if badges display correctly in GitHub Pages, as @james-garriss I believe the changes will only display after we push to main? |
Correct. If you want to test before PR, you can clone repo, make changes to show the badge on its main, and see what happens. |
f977b1e
to
5505294
Compare
@nanda-katikaneni Ready to merge |
🗣 Description
Add license, GitHub/PSGallery versions, CICD workflow, open issues, and GitHub/PSGallery download badges to the README with respective links.
💭 Motivation and context
Resolves #1166
🧪 Testing
✅ Pre-approval checklist
Unit tests added/updated to cover PowerShell and Rego changes.Functional tests added/updated to cover PowerShell and Rego changes.All relevant functional tests passed.✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
✅ Post-merge checklist