Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Azure AD policy (MS.AAD.5.2v1) instructions to match updated UI buttonology #1117

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Updated Azure AD policy (MS.AAD.5.2v1) instructions to match updated UI buttonology #1117

merged 3 commits into from
Jun 25, 2024

Conversation

ahuynhMITRE
Copy link
Collaborator

@ahuynhMITRE ahuynhMITRE commented May 28, 2024 •
edited
Loading

🗣 Description

Currently the MS.AAD.5.2v1 policy Instructions are inconsistent with M365 Identity UI (it is also inconsistent with other related policies 5.3v1 and 5.4v1). Modify instructions to align with new UI buttonology.

💭 Motivation and context

Change required to align with current UI buttonology and be consistent with the other related policies.

Closes #1044

🧪 Testing

N/A, markdown change only.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@ahuynhMITRE ahuynhMITRE added the baseline-document Issues relating to the text in the baseline documents themselves label May 28, 2024
@ahuynhMITRE ahuynhMITRE added this to the Halibut milestone May 28, 2024
@ahuynhMITRE ahuynhMITRE self-assigned this May 28, 2024
@ahuynhMITRE ahuynhMITRE linked an issue May 28, 2024 that may be closed by this pull request
Azure AD policy (MS.AAD.5.2v1) instructions need an update. #1044
Closed
nanda-katikaneni
nanda-katikaneni approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@nanda-katikaneni nanda-katikaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@schrolla schrolla modified the milestones: Halibut, Iceberg May 30, 2024
@ahuynhMITRE
Copy link
Collaborator Author

@nanda-katikaneni good to merge now that we are on iceberg

1 similar comment
@ahuynhMITRE
Copy link
Collaborator Author

@nanda-katikaneni good to merge now that we are on iceberg

@nanda-katikaneni
Copy link
Collaborator

@nanda-katikaneni good to merge now that we are on iceberg

@ahuynhMITRE, can you please check PowerShell link failures (may not be related to the changes made in this pr but the pipeline lint test is failing on the branch).

@ahuynhMITRE
Copy link
Collaborator Author

@nanda-katikaneni good to merge now that we are on iceberg

@ahuynhMITRE, can you please check PowerShell link failures (may not be related to the changes made in this pr but the pipeline lint test is failing on the branch).

all checks have now passed!

@nanda-katikaneni nanda-katikaneni merged commit 213a912 into main Jun 25, 2024
14 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 1044-azure-ad-policy-msaad52v1-instructions-need-an-update branch June 25, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchelbaker-cisa mitchelbaker-cisa mitchelbaker-cisa approved these changes

@nanda-katikaneni nanda-katikaneni nanda-katikaneni approved these changes

Assignees

@ahuynhMITRE ahuynhMITRE

Labels
baseline-document Issues relating to the text in the baseline documents themselves
Projects
None yet
Milestone
Iceberg
Development

Successfully merging this pull request may close these issues.

Azure AD policy (MS.AAD.5.2v1) instructions need an update.
4 participants
@ahuynhMITRE @nanda-katikaneni @mitchelbaker-cisa @schrolla