Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetcher: avoid response deadlock #975

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Fetcher: avoid response deadlock #975

merged 1 commit into from
Dec 16, 2024

Conversation

edigaryev
Copy link
Collaborator

@edigaryev edigaryev commented Dec 16, 2024 •
edited
Loading

Problem: it's possible that an error is generated in didCompleteWithError callback before receiving the response.

Solution: make sure that we propagate the error to the responseContinuation too to unlock it.

Also, set continuations to nil to avoid resuming them twice, just in case.

@edigaryev edigaryev requested a review from fkorotkov as a code owner December 16, 2024 20:38
@edigaryev edigaryev merged commit e27da23 into main Dec 16, 2024
7 checks passed
@edigaryev edigaryev deleted the fetcher-avoid-response-deadlock branch December 16, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkorotkov fkorotkov fkorotkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edigaryev @fkorotkov