Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tart set: support --{,no-}display-auto-reconfigure #954

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

edigaryev
Copy link
Collaborator

A simpler approach with direct VMConfig.displayAutoReconfigure access, inverted flag (to support prepending --no-*) and backwards compatibility (according to the truth table).

/cc @Fred78290

Resolves #951.

@edigaryev edigaryev requested a review from fkorotkov as a code owner November 19, 2024 14:40
@edigaryev
Copy link
Collaborator Author

I'm also wondering if we should shorten the option name to --display-auto or --display-reconfigure.

@fkorotkov @Fred78290 what do you think?

@Fred78290
Copy link
Contributor

I'm also wondering if we should shorten the option name to --display-auto or --display-reconfigure.

@fkorotkov @Fred78290 what do you think?

I suggest --refit-display

@edigaryev
Copy link
Collaborator Author

I suggest --refit-display

Would --display-refit work for you?

To semantically group it with the --display option.

fkorotkov
fkorotkov previously approved these changes Nov 19, 2024
@Fred78290
Copy link
Contributor

@edigaryev

It should be more simplier to use

@Flag(name: [.customLong("display-refit")]

@edigaryev
Copy link
Collaborator Author

It should be more simplier to use

Why do we need .customLong if the argument's name is already automatically derived from the property’s name?

@edigaryev edigaryev merged commit 8536c16 into main Nov 20, 2024
6 checks passed
@edigaryev edigaryev deleted the tart-set-display-auto-reconfigure branch November 20, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants