Async http client for pull/push #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edigaryev
reviewed
May 20, 2022
Sources/tart/OCI/Registry.swift
Outdated
| case MissingLocationHeader | ||
| case AuthFailed(why: String, details: String = "") | ||
| case MalformedHeader(why: String) | ||
| } | ||
|
|
||
| private let MAX_TEXT_RESPONSE_SIZE = 1024 * 1024 |
There was a problem hiding this comment.
Looks like an unused variable.
edigaryev
previously approved these changes
May 20, 2022
fkorotkov
force-pushed
the
async-http-client
branch
from
0077f23 to
0047dc0
Compare
edigaryev
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with #41
I've tested by pulling and pushing an image.