tart {clone,pull}: make deduplication opt-in #924
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #864, deduplication is a somewhat controversial feature that might result in noticeably slower pulls with larger network speeds (think 10 Gbps) due to disk reads and comparisons needed.
Also, hole punching mechanism used for deduplication can presumably result in APFS performance degradation later, when running the cloned VMs.
On the other hand, typical disk space savings observed for Cirrus Labs images are around 12 GB per pulled VM, which might not worth the extra complexity involved and potential performance implications.