Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tart {clone,pull}: make deduplication opt-in #924

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

edigaryev
Copy link
Collaborator

@edigaryev edigaryev commented Oct 25, 2024

As noted in #864, deduplication is a somewhat controversial feature that might result in noticeably slower pulls with larger network speeds (think 10 Gbps) due to disk reads and comparisons needed.

Also, hole punching mechanism used for deduplication can presumably result in APFS performance degradation later, when running the cloned VMs.

On the other hand, typical disk space savings observed for Cirrus Labs images are around 12 GB per pulled VM, which might not worth the extra complexity involved and potential performance implications.

@edigaryev edigaryev requested a review from fkorotkov as a code owner October 25, 2024 09:22
Copy link
Contributor

@fkorotkov fkorotkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just don't call chooseLocalLayerCache at all if the deduplication flag is false instead of passing deduplicate everywhere?

@edigaryev
Copy link
Collaborator Author

Should we just don't call chooseLocalLayerCache at all if the deduplication flag is false instead of passing deduplicate everywhere?

In this case we won't re-use the chunks from other VM images in the OCI cache if there's a match.

This behavior was introduced by #825.

Why give it up?

@edigaryev edigaryev merged commit b52a857 into main Oct 25, 2024
7 checks passed
@edigaryev edigaryev deleted the make-deduplication-opt-in branch October 25, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants