Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect boot_wait for VNC #88

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Respect boot_wait for VNC #88

merged 4 commits into from
Aug 24, 2023

Conversation

BytesGuy
Copy link
Contributor

Currently the boot_wait command does not do anything, even though it is documented as "The time to wait after booting the initial virtual machine before typing the boot_command".

Currently the workaround I have been using is to add <wait90s> in the boot_command, which works but makes the config a little harder to follow.

It seems this was caused as the boot wait was not currently implemented fully, so this PR adds this functionality.

For example, setting boot_wait = "90s" will now produce:

==> tart-cli.vm: Starting the virtual machine...
==> tart-cli.vm: Waiting for the VNC server credentials from Tart...
==> tart-cli.vm: Retrieved VNC credentials, connecting...
==> tart-cli.vm: Connected to the VNC!
==> tart-cli.vm: Waiting 1m30s for VM to boot...
==> tart-cli.vm: Typing the commands over VNC...

This allows time for the VM to boot properly before VNC commands are issued, preventing unexpected behaviour.

Copy link
Contributor

@fkorotkov fkorotkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for noting! And thank you so much for the PR! Left two minor notes.

@fkorotkov fkorotkov requested a review from edigaryev August 23, 2023 00:46
@fkorotkov fkorotkov merged commit e8dba1c into cirruslabs:main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants