Persistent Worker: allow pre-pulling specified Tart VMs periodically #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
reviewed
Oct 1, 2024
Comment on lines
+238
to
+246
| // Pre-pull the configured Tart VM images first | ||
| for _, image := range worker.tartPrePull { | ||
| worker.logger.Infof("pre-pulling Tart VM image %q...", image) | ||
|
|
||
| if err := tart.PrePull(ctx, image, worker.echelonLogger); err != nil { | ||
| worker.logger.Errorf("failed to pre-pull Tart VM image %q: %v", image, err) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Should it be after the next next if statement after locking resources and just before warmup?
There was a problem hiding this comment.
Good catch, moved in c7b6903.
fkorotkov
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be configured as follows:
Only works when standby is configured and only triggers before the standby creation/re-creation.