Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cirrus run: introduce --lazy-pull flag #517

Merged
merged 4 commits into from
May 16, 2022
Merged

cirrus run: introduce --lazy-pull flag #517

merged 4 commits into from
May 16, 2022

Conversation

edigaryev
Copy link
Contributor

@edigaryev edigaryev commented May 15, 2022 •
edited
Loading

Resolves #510.

@edigaryev edigaryev requested a review from fkorotkov May 15, 2022 18:19
@edigaryev
Copy link
Contributor Author

edigaryev commented May 15, 2022 •
edited
Loading

@fkorotkov tart binary on the test machine needs to be updated to include cirruslabs/tart#70 for the tests to pass.

@fkorotkov
Copy link
Contributor

Just cut 0.3.0 release and it should be available shortly. I think we can add something like brew upgrade cirruslabs/cli/tart to the scripts to always test agains the latest one.

@fkorotkov
Copy link
Contributor

In the meantime I've upgraded the worked so now it should work.

@edigaryev
Copy link
Contributor Author

Just cut 0.3.0 release and it should be available shortly. I think we can add something like brew upgrade cirruslabs/cli/tart to the scripts to always test agains the latest one.

Seems that the PR didn't make it through yet.

@fkorotkov
Copy link
Contributor

I thought it got merged. My bad!

fkorotkov
fkorotkov reviewed May 16, 2022
View reviewed changes
internal/commands/run.go
NoCleanup: debugNoCleanup,

DockerfileImageTemplate: dockerfileImageTemplate,
DockerfileImagePush: dockerfileImagePush,
}))

// Tart-related options
executorOpts = append(executorOpts, executor.WithTartOptions(options.TartOptions{
LazyPull: lazyPull || tartLazyPull,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it also be called EagerPull for consistency&

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was called like that before ef89082, where I've changed the meaning so that each newly-initialized TartOptions struct would reflect the defaults.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the container option be renamed into LazyPull then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See 241da4f.

internal/executor/instance/persistentworker/isolation/tart/vm.go Show resolved Hide resolved
@edigaryev edigaryev requested a review from fkorotkov May 16, 2022 13:43
@edigaryev edigaryev enabled auto-merge (squash) May 16, 2022 13:44
@edigaryev edigaryev merged commit 07e299a into master May 16, 2022
@edigaryev edigaryev deleted the lazy-pull branch May 16, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkorotkov fkorotkov fkorotkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--lazy-pull flag
2 participants
@edigaryev @fkorotkov