Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand mapping values with environment variables #221

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Expand mapping values with environment variables #221

merged 2 commits into from
Jan 7, 2021

Conversation

fkorotkov
Copy link
Contributor

@fkorotkov fkorotkov merged commit 683bfe6 into master Jan 7, 2021
@fkorotkov fkorotkov deleted the expanded-mapping branch January 7, 2021 18:20
fkorotkov added a commit that referenced this pull request Jan 8, 2021
@fkorotkov
Revert "Expand mapping values with environment variables (#221)"
df366c6 
This reverts commit 683bfe6

Since some folks use encrypted variables as docker arguments.
@fkorotkov
Copy link
Contributor Author

Reverted in df366c6. It appeared some folks pass encrypted variables as arguments (which is a security risk since docker image will contain the variable unencrypted).

@real-or-random real-or-random mentioned this pull request Jan 29, 2021
Merged
6 tasks
@real-or-random
Copy link

Reverted in df366c6. It appeared some folks pass encrypted variables as arguments (which is a security risk since docker image will contain the variable unencrypted).

Makes sense. In this case, cirruslabs/cirrus-ci-docs#544 is the simplest change that will help people when they're having issues with the cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fkorotkov @real-or-random