Parallels isolation support #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
reviewed
Dec 29, 2020
fkorotkov
reviewed
Dec 30, 2020
|
|
||
| func NewVMClonedFrom(ctx context.Context, vmNameFrom string) (*VM, error) { | ||
| vm := &VM{ | ||
| name: "cirrus-" + uuid.New().String(), |
There was a problem hiding this comment.
Maybe use task id so the error message will be self explanatory and not confusing?
There was a problem hiding this comment.
It's already there:
cirrus-cli/internal/worker/task.go
Line 50 in ed3e710
There was a problem hiding this comment.
But error from prlctl are propagated to user and these errors contain this unique VM name without the task id.
fkorotkov
reviewed
Dec 30, 2020
internal/executor/instance/persistentworker/isolation/parallels/vm.go
Outdated
Show resolved
Hide resolved
fkorotkov
reviewed
Dec 30, 2020
internal/executor/instance/persistentworker/isolation/parallels/vm.go
Outdated
Show resolved
Hide resolved
…s/vm.go Co-authored-by: Fedor Korotkov <[email protected]>
…s/vm.go Co-authored-by: Fedor Korotkov <[email protected]>
fkorotkov
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #198.