-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Podman support #151
Podman support #151
Conversation
...and introduce ContainerBackendFromEnv test helper to pick up the backend from CIRRUS_CONTAINER_BACKEND environment variable.
@fkorotkov what do you think about moving |
...to fix the compilation on non-Linux platforms.
I'm reading the Podman's API document and thinking that we could probably combine Using the REST API with the Running as a subprocess to get the best of both worlds. By spawning a An additional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing! What do you think about an option to pass backend as an argument to run
command? Something like cirrus run --backend=podman
. Or we can do in the follow up PR about running podman binary instead of relying on a running podman service.
.cirrus.yml
Outdated
test_script: | ||
- wget --no-verbose -O - https://golang.org/dl/go1.15.linux-amd64.tar.gz | tar -C /usr/local -xz | ||
- export PATH=$PATH:/usr/local/go/bin | ||
- go test ./... | ||
env: | ||
HOME: /root | ||
|
||
docker_builder: | ||
name: Test (Podman) | ||
alias: test-podman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think alias
s are not uniques so you can use "tests" in both tasks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed in e908393.
The most simplest invocation (in the directory with the
.cirrus.yml
) looks like this:The Podman backend will also be automatically selected when no Docker daemon is present on the host.
TestResourceLimits
had to be disabled when running with Podman backend due to containers/podman#7959.There are some things that still need to be done before this gets merged:
DockerOptions
toContainerOptions
and other de-Dockerizations (e.g.'docker pull' succeeded in 4.2s
)