Introduce serve command #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
reviewed
Oct 1, 2020
internal/evaluator/evaluator.go
Outdated
| // Parse combined YAML | ||
| p := parser.New( | ||
| parser.WithEnvironment(request.Environment), | ||
| parser.WithFilesContents(request.FilesContents), |
There was a problem hiding this comment.
Let's also add GitHub FS in case environment contains CIRRUS_REPO_CLONE_TOKEN, CIRRUS_REPO_NAME, CIRRUS_REPO_OWNER and CIRRUS_CHANGE_IN_REPO. Seems this will require the parser to check explicit file contents first and if a file is not presented then check in fs.
There was a problem hiding this comment.
Implemented in 258567d.
I'm not sure why we need to touch files contents or parser at all, though, since GitHub FS is only used by Starlark.
fkorotkov
reviewed
Oct 2, 2020
PTAL at 3cdbd63. |
fkorotkov
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #53.