Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare-instance should persist and pass SSH connection #804

Closed
fkorotkov opened this issue Oct 23, 2024 · 0 comments · Fixed by #805
Closed

prepare-instance should persist and pass SSH connection #804

fkorotkov opened this issue Oct 23, 2024 · 0 comments · Fixed by #805

Comments

@fkorotkov
Copy link
Contributor

I was investigating slower than usual cold startup times for ghcr.io/cirruslabs/macos-runner:sequoia VMs and noticed couple interesting things.

It seems we do try to establish SSH connection to the VM twice and both times it's taking around 5 seconds:

Screenshot 2024-10-23 at 8 00 24 AM

Fixing the missing wait-for-ssh in #803.

For a standby instance both SSH connection and agent uploads just takes hundreds of milliseconds.

Screenshot 2024-10-23 at 8 05 36 AM

It seems we might want to optimize these things by passing by the SSH connection from prepare instance or alternetevely remove this logic from there and add extra logic to standby preparation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant