Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix none error by removing strerror #553

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Conversation

axu2
Copy link
Collaborator

@axu2 axu2 commented Jul 5, 2023

Previously gave unhelpful error message on rar:
image

Now gives proper error.

image

Also removed all other occurrences of strerror

Fixes #528
Fixes #489

Probably fixes #396

@axu2 axu2 changed the title warn p7zip-rar Avoid None errors Jul 5, 2023
@axu2 axu2 marked this pull request as ready for review July 5, 2023 14:40
@axu2 axu2 changed the title Avoid None errors Fix unhelpful none error Jul 5, 2023
@darodi darodi self-requested a review July 5, 2023 16:53
@darodi darodi merged commit a520245 into ciromattia:master Jul 5, 2023
@darodi
Copy link
Collaborator

darodi commented Jul 5, 2023

Thanks for your PR! :)

@darodi darodi added this to the 5.6.3 milestone Jul 5, 2023
@axu2 axu2 deleted the p7zip-rar branch July 5, 2023 17:45
@axu2 axu2 changed the title Fix unhelpful none error Fix none error Jul 6, 2023
@axu2 axu2 changed the title Fix none error Fix none error by removing strerror Jul 7, 2023
axu2 added a commit to axu2/kcc that referenced this pull request Jul 16, 2023
* warn p7zip-rar

* replace strerror
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants