-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add native Apple Silicon support by upgrading qt5 to qt6 #523
Conversation
The main problem here is that the apple silicon is not supported via github actions. pyqt5 is available and works during build. https://github.com/celogeek/go-comic-converter might be a better solution, it can compile on every platform but I admit that migrating to pyqt6 (or even another GUI?) will be needed in the end. |
Note for later, |
beta release here Windows is ok |
appImage is broken
|
Docker image is fine on platform=linux/amd64
and mobi output can be read |
so just the appImage to fix. I'll have a look. |
docker is broken on platform=linux/arm/v7
|
I did bump the psutil version due to security but maybe I bumped it too high? |
I'll have a look and update the Docker image next week |
M1 runners out! I'll figure it out and test. Edit: not free yet |
I've been able to make the appImage work with pyqt6 and python 3.12 |
On posix isn't it supposed to be in '/usr/local/bin'? 'kcc.py' modifies PATH for 7z/kindlegen on win/mac |
same problem with version 5.6.2 in fact |
FlyCI has M1 and M2 runners with a free tier for M1s. Our runners are on average 2x faster and 2x cheaper than GitHub's. Install InstructrionsEasily replace your M1 runners: jobs:
ci:
- runs-on: macos-latest
+ runs-on: flyci-macos-large-latest-m1
steps:
- name: 👀 Checkout repo
uses: actions/checkout@v4 Or try the M2 runners: jobs:
ci:
- runs-on: macos-latest
+ runs-on: flyci-macos-large-latest-m2
steps:
- name: 👀 Checkout repo
uses: actions/checkout@v4 Pricing
500 mins/month Free for Public ReposIf your repo is public, then FlyCI offers 500 mins/month of free M1 runner usage with the Best Regards, |
I upgraded to pyside6 which has native Apple Silicon support. (aka a vanilla
pip install pyside6
works).My process was:
gen_ui_files.sh
python kcc.py
change all occurences
replacement.Porting to PySide6 is actually easier than PyQT6 since PyQT6 dropped pyrcc. PySide6 is also the official library now.
Note that
KCC_rcc.py
,KCC_ui.py
,KCC_ui_editor.py
, were autogenerated by pyside6-uic and pyside6-rccKCC_gui.py
was manually edited.This has been the base for testing all my other PRs on Mac, extensively tested.