-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: JSONEncoded should be encoded as json not jsonb #347
Conversation
This is a breaking change |
I have a feeling we are relying on |
Maybe the right thing to do in that case is have |
How about this instead @ocharles ? |
Yea this looks good - I'll have to remind myself how |
Actually I'm going to inline some of this to make it a bit clearer and mirror JSONBEncoded |
SGTM! |
I've added a test case as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Resolves #344