Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer job names -- prefix with system and sort #17

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Nicer job names -- prefix with system and sort #17

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7989844
Prefix labels with system
brprice Aug 17, 2022
79dee54
Also prefix with emoji representing OS where possible
brprice Aug 17, 2022
18480e7
Sort steps by label
brprice Aug 17, 2022
0fc81b9
Don't prefix our 'required' job, as github expects a job of this name
brprice Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 38 additions & 13 deletions exe-nix-buildkite/Main.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import Data.Attoparsec.Text ( parseOnly )

-- base
import Data.Char
import Data.List ( sortOn )
import Data.Maybe ( fromMaybe, listToMaybe )
import Data.Traversable ( for )
import qualified Prelude
Expand All @@ -37,10 +38,11 @@ import System.FilePath
import Nix.Derivation

-- process
import System.Process hiding ( env )
import System.Process hiding ( env, system )

-- text
import Data.Text ( pack, unpack )
import Data.Text ( Text, pack, unpack )
import qualified Data.Text as T
import Data.Text.IO ( readFile )


Expand All @@ -54,6 +56,10 @@ main = do
Nothing -> return []
Just path -> return $ [ "--post-build-hook", path ]

-- TODO: this should be made into an option
-- (and probably should add options for prefixing at all, using emoji, and sorting also)
let skipPrefix = [ "required" ]

-- Run nix-instantiate on the jobs expression to instantiate .drvs for all
-- things that may need to be built.
inputDrvPaths <- nubOrd . Prelude.lines <$> readProcess "nix-instantiate" [ jobsExpr ] ""
Expand All @@ -68,30 +74,49 @@ main = do
return (pack (takeFileName drvPath), drvPath)

Right drv ->
case Map.lookup "name" (env drv) of
Nothing ->
-- There was no 'name' environment variable, so we'll just use the
-- derivation name.
return (pack (takeFileName drvPath), drvPath)

Just name ->
return (name, drvPath)
let name = case Map.lookup "name" (env drv) of
Nothing ->
-- There was no 'name' environment variable, so we'll just use the
-- derivation name.
pack (takeFileName drvPath)
Just n -> n
system = if name `elem` skipPrefix
then ""
else case Map.lookup "system" (env drv) of
Nothing -> ""
Just s -> emojify s <> ":"
in return (system <> name, drvPath)

g <- foldr (\(_, drv) m -> m >>= \g -> add g drv) (pure empty) drvs

let steps = map (uncurry step) drvs
where
step label drvPath =
step label drvPath = (label,
object
[ "label" .= unpack label
, "command" .= String (pack $ unwords $ [ "nix-store" ] <> postBuildHook <> [ "-r", drvPath ])
, "key" .= stepify drvPath
, "depends_on" .= dependencies
]
])
where
dependencies = map stepify $ filter (`elem` map snd drvs) $ drop 1 $ reachable drvPath g

Data.ByteString.Lazy.putStr $ encode $ object [ "steps" .= steps ]
Data.ByteString.Lazy.putStr $ encode $ object [ "steps" .= map snd ( sortOn fst steps ) ]

-- Transform nix platforms into buildkite emoji
-- See https://github.com/buildkite/emojis
emojify :: Text -> Text
emojify system =
let (_,os) = T.breakOnEnd "-" system
in toEmoji os <> system
where
toEmoji "darwin" = ":darwin: "
toEmoji "freebsd" = ":freebsd: "
toEmoji "linux" = ":linux: "
toEmoji "netbsd" = ":netbsd: "
toEmoji "openbsd" = ":openbsd: "
toEmoji "windows" = ":windows: "
toEmoji _ = ""

stepify :: String -> String
stepify = take 99 . map replace . takeBaseName
Expand Down