Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoder: add optional filename param, parse bytes as hex #203

Merged
merged 3 commits into from
Aug 16, 2018

Conversation

walkerq
Copy link
Contributor

@walkerq walkerq commented Aug 15, 2018

No description provided.

package.json Outdated
@@ -37,6 +37,7 @@
"openzeppelin-solidity": "1.11.0",
"path": "^0.12.7",
"q": "^1.5.1",
"web3": "^1.0.0-beta.35",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to be using the beta version?

Copy link
Contributor Author

@walkerq walkerq Aug 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just changed it back to latest maintenance version, 0.20.6

if (result.types[i] == "bytes") {
result.inputs[i] = web3.utils.bytesToHex(result.inputs[i])
}

}

var decodedDataJson = JSON.stringify(result)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it should probably write to a file or output to command line, but not both.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, changed

@o-a-hudson o-a-hudson merged commit 42e2644 into circlefin:master Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants