add utility script for generating transaction data field #183
Conversation
buildTransactionData.js
Outdated
|
|
||
| const abi = require('ethereumjs-abi') | ||
|
|
||
| function encodeCall(name, arguments, values) { |
There was a problem hiding this comment.
Can we share this code with where it is being used in the tests - just don't want to repeat it in more than one place.
There was a problem hiding this comment.
The problem with requiring it from TokenTestUtils is that file uses artifacts.require so it has to be run within truffle tests, whereas this is a standalone script that can be run by node. We could factor out encodeCall to somewhere else and have both this file and TokenTestUtils import from there. It will just involve changing the import on all the tests that use encodeCall
There was a problem hiding this comment.
OK. In this case then we should define encodeCall in a separate file as you say and have both import the file.
There was a problem hiding this comment.
If we made this a truffle script, could we use the artifacts so we wouldn't need the type parameters anymore?
var FiatTokenV2 = artifacts.require('FiatTokenV2');
FiatTokenV2[name].request(param1, param2, ...)
buildTransactionData.js
Outdated
| @@ -0,0 +1,44 @@ | |||
| // Description: | |||
There was a problem hiding this comment.
Can we put this in a scripts directory - somewhere other than the root dir?
scripts/buildTransactionData.js
Outdated
|
|
||
| module.exports = async function(callback) { | ||
| await run(); | ||
| } |
There was a problem hiding this comment.
Minor, but the truffle docs say we should call the callback at the end of the script
https://truffleframework.com/docs/getting_started/scripts
| args = args.slice(1) | ||
|
|
||
| var data = tokenVX[func].request.apply(null, args)["params"][0]["data"] | ||
| console.log(data) |
There was a problem hiding this comment.
Nice - so we could use this with any contracts we have. That will be super useful.
test/MiscTests.js
Outdated
| var slot8Data = await web3.eth.getStorageAt(newProxy.address, 8); | ||
| assert.equal("0x00", slot8Data); | ||
| }); | ||
|
|
There was a problem hiding this comment.
What are these other changes here and below? It looks like commits that have already been merged into master? Could you clean up the commit history so we just have your changes in the history and the diff?
…for upgradeToAndCall
o-a-hudson
dismissed
eztierney’s stale review
All requested changes confirmed as completed.
No description provided.