Skip to content

Commit

Permalink
[UNTRACKED] Allow users of this repository as a submodule to override…
Browse files Browse the repository at this point in the history
… the foundry version to use (#55)

## Summary
Allow users of this repository as a submodule to override the foundry
version to use

## Detail
This repository is used as a submodule elsewhere to build evm contracts,
at the same time these other repositories install said contracts using a
locally managed foundry version. when the versions don't align the
builds can sometimes fail causing the need to cascade update the foundry
version everywhere.

Allowing the Dockefile to use a build argument means other downstream
repositories can update the version at their own pace without having to
update this repository first.

## Testing
covered by existing tests

## Documentation

**Story:** [UNTRACKED](https://circlepay.atlassian.net/browse/)
  • Loading branch information
jhilaire-circle authored Dec 20, 2024
1 parent 4b2eb0c commit 5f1901a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Use fixed foundry image
ARG FOUNDRY_VERSION=nightly-4a8c7d0e26a1befa526222e22737740f80a7f1c5

FROM ghcr.io/foundry-rs/foundry:nightly-4a8c7d0e26a1befa526222e22737740f80a7f1c5
FROM ghcr.io/foundry-rs/foundry:${FOUNDRY_VERSION}

# Copy our source code into the container
WORKDIR /app
Expand Down

0 comments on commit 5f1901a

Please sign in to comment.