Skip to content

Commit

Permalink
remove -weak_framework (#89233)
Browse files Browse the repository at this point in the history
Summary:
X-link: pytorch/pytorch#89233

The `-weak_framework` flag is no longer necessary, Buck will weakly link frameworks depending on the `target_sdk_version` of the binary being linked.

Reviewed By: ebgraham, malfet

Differential Revision: D41348639

fbshipit-source-id: 47992282ba030294b2304c550d49df13e24e9c79
  • Loading branch information
rmaz authored and facebook-github-bot committed Nov 18, 2022
1 parent c06323f commit 88d1825
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 12 deletions.
7 changes: 1 addition & 6 deletions BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -406,12 +406,6 @@ rn_apple_xplat_cxx_library(
"-Wno-global-constructors",
],
contacts = ["[email protected]"],
exported_linker_flags = [
"-weak_framework",
"UserNotifications",
"-weak_framework",
"WebKit",
],
exported_preprocessor_flags = rn_extra_build_flags(),
fbobjc_enable_exceptions = True,
frameworks = [
Expand All @@ -426,6 +420,7 @@ rn_apple_xplat_cxx_library(
"$SDKROOT/System/Library/Frameworks/SystemConfiguration.framework",
"$SDKROOT/System/Library/Frameworks/UIKit.framework",
"$SDKROOT/System/Library/Frameworks/UserNotifications.framework",
"$SDKROOT/System/Library/Frameworks/WebKit.framework",
],
labels = [
"depslint_never_add",
Expand Down
8 changes: 2 additions & 6 deletions React/CoreModules/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,13 @@ rn_apple_library(
],
contacts = ["[email protected]"],
enable_exceptions = True,
exported_linker_flags = [
"-weak_framework",
"UserNotifications",
"-weak_framework",
"WebKit",
],
exported_preprocessor_flags = rn_extra_build_flags(),
extension_api_only = True,
frameworks = [
"Foundation",
"UIKit",
"UserNotifications",
"WebKit",
],
header_path_prefix = "React",
labels = [
Expand Down

0 comments on commit 88d1825

Please sign in to comment.