Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile editor in settings #91

Merged
merged 7 commits into from
Sep 13, 2021
Merged

Conversation

jamesjulich
Copy link
Contributor

@jamesjulich jamesjulich commented Sep 9, 2021

Description

This change adds a profile editor in the settings panel that allows users to change their display name and profile picture. It does not include an upload progress spinner or a hover animation on the image upload portion. The image uploader was created as a component in the atoms folder. You can pass a function to the image upload component to perform an action when an image is uploaded.

Note: I am very new to React. There are probably going to be issues/things I could have done differently/better in this PR. If you see something that could be better, please let me know so that I can improve in the future. Thanks for being such a welcoming community. I felt like it was really easy to get involved, and I really appreciate that!

image

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@ajbura ajbura deleted the branch cinnyapp:dev September 9, 2021 14:17
@ajbura ajbura closed this Sep 9, 2021
@ajbura ajbura reopened this Sep 9, 2021
@jamesjulich jamesjulich closed this Sep 9, 2021
@jamesjulich jamesjulich reopened this Sep 9, 2021
@ajbura ajbura self-requested a review September 13, 2021 08:05
Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work James! 🎉

@ajbura ajbura merged commit 64abfd4 into cinnyapp:dev Sep 13, 2021
@jamesjulich jamesjulich deleted the profile-editor branch September 14, 2021 03:48
greentore pushed a commit to greentore/greeny that referenced this pull request Feb 13, 2023
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.86 to 1.0.87.
- [Release notes](https://github.com/serde-rs/json/releases)
- [Commits](serde-rs/json@v1.0.86...v1.0.87)

---
updated-dependencies:
- dependency-name: serde_json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
RainbowTabitha pushed a commit to FurConnect/app that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants