Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better password check #716

Closed
wants to merge 3 commits into from
Closed

Conversation

ginnyTheCat
Copy link
Collaborator

@ginnyTheCat ginnyTheCat commented Aug 5, 2022

Description

Adds more resilient password checks using the zxcvbn library. As it contains many tables to check against the library is pretty big. To mitigate this problem the Auth component is now only loaded when the user is not yet logged in.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Preview: https://716--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@ginnyTheCat ginnyTheCat force-pushed the password branch 3 times, most recently from c53e221 to defc881 Compare August 12, 2022 21:15
Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading zxcvbn in login page increase our loading time even when we don't want to create an account.

Also password like:
image
is not acceptable but
image
is acceptable

where both are not a strong password and homeserver may reject it.

see: https://spec.matrix.org/v1.3/client-server-api/#notes-on-password-management

@ginnyTheCat ginnyTheCat force-pushed the password branch 2 times, most recently from cf53378 to a9770fc Compare August 21, 2022 11:27
@ginnyTheCat ginnyTheCat force-pushed the password branch 5 times, most recently from f5cead0 to 0233600 Compare September 8, 2022 19:53
@ginnyTheCat ginnyTheCat marked this pull request as draft September 11, 2022 04:35
@kfiven
Copy link
Collaborator

kfiven commented May 22, 2024

Closing as stale.

@kfiven kfiven closed this May 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants