-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for building docker image for linux/arm64 #494
Conversation
Btw build times has gone 10x, and I don't know why. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kfiven, since we use qemu to build arm64 (a non-native platform for the gh-action VMs), it takes much longer. It would be recommended to build arm64 images only when a new tag is pushed (as possibly multiple build processes can run at the same time and overwrite the other one, depending on which one finishes first)
I would like to have this merged as I have a multi-arch Kubernetes cluster I would like to deploy this on. |
why not just build with whatever system you are running on then just use the arm64 of nginx for example? |
linux/arm/v7 is also requested in issue #489, is it possible to build that also? |
No, we have a dependency that needs a library that is not available on arm/v7 yet https://github.com/kfiven/cinny/runs/6072704815?check_suite_focus=true#step:7:565
|
* Update docker-pr.yml * setup docker build for linux/arm64 * Update prod-deploy.yml * Apply PR suggestion
Description
This PR add support to build docker image for linux/arm64 platform. Currently we only have it for linux/amd64.
Fixes #489
Type of change
Checklist:
Preview: https://6291e81eb669225c2ec924b6--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️