Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix can't open spaces from public room list #419

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Fix can't open spaces from public room list #419

merged 1 commit into from
Mar 23, 2022

Conversation

ajbura
Copy link
Member

@ajbura ajbura commented Mar 23, 2022 •
edited by github-actions bot
Loading

Signed-off-by: Ajay Bura [email protected]

Description

Fixes #413

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Preview: https://623aed564f3e503600deaace--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@kfiven
Copy link
Collaborator

kfiven commented Mar 23, 2022

If I am not mistaken, this also fix #412 ?

@ajbura
Copy link
Member Author

ajbura commented Mar 23, 2022

Yes.

@ajbura ajbura merged commit 0f97de1 into dev Mar 23, 2022
@ajbura ajbura mentioned this pull request Mar 23, 2022
Closed
@ajbura ajbura deleted the fix-413 branch April 24, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfiven kfiven kfiven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Spaces if joined doesn't show joined in Public rooms list
2 participants
@ajbura @kfiven