-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Desktop notifications #252
Conversation
I am ok with asking notification permission after login. Also I am getting the following error with crash when opening notifications tab in settings in Safari: |
8e253f1
to
ed99f2f
Compare
It should not crash in Safari now and asks for permission on startup. |
5434d6f
to
95568bd
Compare
Description
This adds Desktop notification support.
(These screenshots are taken in GNOME. They will look different on Windows and macOS.)
This change will however not play a custom sound like element web does. The OS will play a generic notification sound on it's own. Adding this feature at a later date however wouldn't be difficult.
Currently Cinny does not ask for notification permission by default on first launch like element web does. The permission can be granted by going to
settings > notifications > request permission
. Personally I think the element approach is more intuitive for new users. If the maintainers are ok with Cinny asking for notification permission after the first login I am more than happy to add this.Fixes #182
Type of change
Checklist:
Preview: https://61f417e0a83c150ef05c7d85--pr-cinny.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.