Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notifications not being sent on decryption correction #1992

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix notifications not being sent on decryption correction #1992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/app/pages/client/ClientNonUIFeatures.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,14 @@ function MessageNotifications() {
const cachedUnreadInfo = unreadCacheRef.current.get(room.roomId);
unreadCacheRef.current.set(room.roomId, unreadInfo);

if (unreadInfo.total === 0) return;
if (unreadInfo.total === 0) {
const handleUnreadEvent: RoomEventHandlerMap[RoomEvent.UnreadNotifications] = () => {
handleTimelineEvent(mEvent, room, toStartOfTimeline, removed, data);
room.removeListener(RoomEvent.UnreadNotifications, handleUnreadEvent);
};
room.on(RoomEvent.UnreadNotifications, handleUnreadEvent);
Comment on lines +208 to +212
Copy link
Member

@ajbura ajbura Nov 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since you are removing the listener inside event handler, it feels like to me that following change may lead to memory leaks where the event handler is set but never gets removed because you never hear from it?

return;
}
if (
cachedUnreadInfo &&
unreadEqual(unreadInfoToUnread(cachedUnreadInfo), unreadInfoToUnread(unreadInfo))
Expand Down