Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String Queries and Multi-Brushing #20

Merged
merged 38 commits into from
Aug 24, 2022
Merged

String Queries and Multi-Brushing #20

merged 38 commits into from
Aug 24, 2022

Conversation

miketynes
Copy link
Contributor

String Queries and Multi-Brushing

Features added

  1. Ability to use query expressions for string variables. Inputs to the string query boxes shown below are interpreted as regex.
  2. Multiple brushes per PCoord Axis. This was necessary to enable string queries without fundamentally changing how queries work.

image

Notes/questions:

  1. The multiple brush implementation is based on that found here.
  2. The brush-on-read filterSelection method was only changed enough to prevent breaking it. It was not given support for multiple-brushes or regex searching. If this is desired I can add it.
  3. I did not modify this method to support multiple brushes since, as far as I can tell, it is not used anywhere across cinema_components, cinema_explorer or cinema_bandit. This means I can't test any changes I make. Am I missing something? Or should this function be removed?
  4. Please let me know if you have suggestions for this cosmetic issue.

miketynes and others added 30 commits December 3, 2021 13:46
@miketynes
ignore jetbrains data
c1e3e43
@miketynes
first pass download link
a6ec4c8
@miketynes
String Queries and Multi-Brushing (#1)
8bdbd96 
Squash and merge. Next step: PR into the parent repo.
@miketynes
begin work on detailDisplay
928cd3a 
create the div within the dataDisplay and populate it
next step: actually include data dimensions
@miketynes
refactor as d3 selection join
a4346c0
@miketynes
populate detailDisplay with data
6c5870c
@miketynes
failed attempt checkpoint
229ffd8 
try to add an update method, doesnt work
@miketynes
works kindof; just for first pane
f903126
@miketynes
there it is!
fe826f6
@miketynes
rm todo
5e56494
@miketynes
track index in div
338e696
@miketynes
add goToPageWithIx
9f2c5a8
@miketynes
dynamically size detailDisplay
dd8be0b 
This almost works, except for some reasons the images arent read
until after the divs get created, so the resulting heights
are too small. I will just hard code height and width for now...
@miketynes
detail size from image size node
44bbdb0
@miketynes
fix coupling between imagesize and detaildisplay
0e73d69
@miketynes
wrap on word break in detail display
cf26f73
@miketynes
dont ignore build
f787b5f
@miketynes
Set theme jekyll-theme-minimal
353d199
@miketynes
Merge pull request #17 from miketynes/file_downloads
7e4a545 
lgtm
@miketynes
dont ignore build
db3bd60
@miketynes
preliminary text preview
b1c36a5
@miketynes
add .display.textDisplay; resizing, margin WIP
34b7428 
The resizing causes the text displays and detail displays to overlap
and I cant quite figure out why
@miketynes
fix resizing
485c556
@miketynes
3dmoljs support
95a4ebe
@carson-sue
Added ability to lock Pcoord selection
bf112c1
@miketynes
handle missing files gracefully
5bc61df
@carson-sue
Can lock by clicking on scatter or imagespread
a2e9c83
@miketynes
Merge pull request #21 from miketynes/3dmoljs
a80970b 
3dmoljs
@miketynes
Merge pull request #22 from miketynes/3dmoljs
c4091a2 
3dmoljs
@miketynes
rm commented lines
6d14f15
@dhrogers dhrogers merged commit 0168de4 into cinemascience:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miketynes @dhrogers @carson-sue