test: fix flaky drain test #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason to hold the mutex while waiting for the routines to return, thus release the mutex early. While here, add a comment that explains why it's safe to close the tasks channel. Signed-off-by: Robin Hahling <[email protected]>
This check turns out to be flaky. It should be implemented in a separate test instead. Signed-off-by: Robin Hahling <[email protected]>
Signed-off-by: Robin Hahling <[email protected]>
tklauser
approved these changes
Feb 3, 2021
| wp.wg.Wait() | ||
|
|
||
| // At this point, all routines have returned. This means that Submit is not |
There was a problem hiding this comment.
💯 thanks for adding that comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details. This should fix #2 (I could not reproduce the failure with over a 100 test runs locally).