add comment to explain why it's not necessary to hold a lock on results

Signed-off-by: Robin Hahling <[email protected]>
cilium · Feb 3, 2021 · 32bff70 · 32bff70
1 parent 986656c
commit 32bff70
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/workerpool.go b/workerpool.go
@@ -120,6 +120,9 @@ func (wp *WorkerPool) Drain() ([]Task, error) {
 
 	wp.wg.Wait()
 
+	// It's not necessary to hold a lock when reading wp.results as no other
+	// routine is running at this point besides the "run" routine which should
+	// be waiting on the tasks channel.
 	res := make([]Task, len(wp.results))
 	for i, t := range wp.results {
 		res[i] = t