-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tetra: add a new debug maps command and move dump under debug #2959
Conversation
c9abfca
to
92fa74d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This looks really, useful!
Some questions; Is this part of bugtool? Should we make it?
Can we have JSON output? JSON output helps if we want to write scripts to parse the data which will be useful if we run this via sysdmp/bugtool across the whole cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, left few comments, thanks
Thanks for the reviews
It's not currently as most commands parts of
agree |
This new command will allow us to debug the map situation and especially regarding memory usage of those maps on host running tetragon. Signed-off-by: Mahe Tardy <[email protected]>
Also creates a hidden alias to not break compatibility with dump being a top command. But now we have the debug command to host those kind of sub commands. Signed-off-by: Mahe Tardy <[email protected]>
92fa74d
to
506cbc4
Compare
I will merge that and add that in a follow-up PR. |
Here is the
help
for this new command:Here is a typical output for tetragon loading with a TCP tracing policy: