action: add -p option mkdir images and fix cache #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtardy
force-pushed
the
pr/mtardy/fix-action-idempotent
branch
7 times, most recently
from
1e26550 to
0a304e6
Compare
Previously it was writting to the root always under /images which could be problematic running on some GHA runners. Signed-off-by: Mahe Tardy <[email protected]>
The path was wrong and thus the cache was never saved. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
force-pushed
the
pr/mtardy/fix-action-idempotent
branch
from
0a304e6 to
ae7d223
Compare
mtardy
changed the title
Otherwise the cache is not used since it stores the compressed version. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
force-pushed
the
pr/mtardy/fix-action-idempotent
branch
from
3b2b49c to
e7ff724
Compare
brb
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can cause the action to fail on a runner on which the /images folder already exists.
Quick and (slightly) dirty fix for my needs to run LVH on hosted arm64 bare metal runners.