Minor improvements to images pull code #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
force-pushed
the
pr/joe/pull-cache-improvements
branch
from
8c618d6 to
4f083c7
Compare
kkourt
approved these changes
Jan 30, 2024
joestringer
commented
Jan 30, 2024
Lorenz and Kornilios pointed out that storing this in a temporary file first is probably not RAM-optimal and complicates the code more than necessary. Simplify this. Signed-off-by: Joe Stringer <[email protected]>
joestringer
force-pushed
the
pr/joe/pull-cache-improvements
branch
from
4f083c7 to
1856713
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from feedback on #152, which was accelerated in order to unblock other efforts.