Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: fix incorrect -d flag #150

Merged
merged 1 commit into from
Jan 25, 2024
Merged

action: fix incorrect -d flag #150

merged 1 commit into from
Jan 25, 2024

Conversation

lmb
Copy link
Collaborator

@lmb lmb commented Jan 25, 2024

lvh images pull doesn't understand -d. The correct flag is --dir.

lvh images pull doesn't understand -d. The correct flag is --dir.

Signed-off-by: Lorenz Bauer <[email protected]>
@lmb
Copy link
Collaborator Author

lmb commented Jan 25, 2024

$ ./lvh images pull --help
Pull an image from an OCI repository

Usage:
  lvh images pull <URL> [flags]

Flags:
      --cache        cache a compressed version of the image
      --dir string   directory to keep the images (images will be saved in images in <dir>/images) (default "_data")
  -h, --help         help for pull

@lmb lmb requested a review from kkourt January 25, 2024 11:23
Copy link
Collaborator

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this never worked? 🤔

@kkourt kkourt merged commit 507847e into main Jan 25, 2024
1 check passed
@kkourt kkourt deleted the lmb/fix-pull-action branch January 25, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants